perf: 优化更多原子操作

Blinue · Nov 29, 2023 · 586025b · 586025b
1 parent 071eee8
commit 586025b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/Magpie.Core/Renderer.cpp b/src/Magpie.Core/Renderer.cpp
@@ -327,17 +327,17 @@ bool Renderer::_BuildEffects() {
 
 	// 并行编译所有效果
 	std::vector<EffectDesc> effectDescs(effectsOption.size());
-	std::atomic<bool> allSuccess = true;
+	std::atomic<bool> anyFailure;
 
 	int duration = Utils::Measure([&]() {
 		Win32Utils::RunParallel([&](uint32_t id) {
 			if (!CompileEffect(id == effectCount - 1, effectsOption[id], effectDescs[id])) {
-				allSuccess = false;
+				anyFailure.store(true, std::memory_order_relaxed);
 			}
 		}, effectCount);
 	});
 
-	if (!allSuccess) {
+	if (anyFailure.load(std::memory_order_relaxed)) {
 		return false;
 	}
 
@@ -390,12 +390,12 @@ bool Renderer::_BuildEffects() {
 						id == 0 ? effectsOption.back() : downscalingEffectOption,
 						id == 0 ? effectDescs.back() : downscalingEffectDesc
 					)) {
-						allSuccess = false;
+						anyFailure.store(true, std::memory_order_relaxed);
 					}
 				}, 2);
 			});
 
-			if (!allSuccess) {
+			if (anyFailure.load(std::memory_order_relaxed)) {
 				return false;
 			}
 

diff --git a/src/Shared/Win32Utils.cpp b/src/Shared/Win32Utils.cpp
@@ -265,7 +265,7 @@ struct TPContext {
 
 static void CALLBACK TPCallback(PTP_CALLBACK_INSTANCE, PVOID context, PTP_WORK) {
 	TPContext* ctxt = (TPContext*)context;
-	uint32_t id = ++ctxt->id;
+	const uint32_t id = ctxt->id.fetch_add(1, std::memory_order_relaxed) + 1;
 	ctxt->func(id);
 }