Implemented event_decoders_test.go #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sh0g0-1758
requested changes
Sep 22, 2024
| } | ||
|
|
||
| // Helper function to parse big integers | ||
| func mustParseBigInt(s string, base int) *big.Int { |
There was a problem hiding this comment.
Move these helper functions to uitls.go
| }{ | ||
| { | ||
| name: "Approval Event", | ||
| abiEvent: NewAbiEvent( |
There was a problem hiding this comment.
How did you get this ? In the original code, I saw that they have loaded an abi for the testing purpose.
There was a problem hiding this comment.
Okay, Lets wait for core.go to be implemented. Then you can use from_json function from it.
There was a problem hiding this comment.
@Sh0g0-1758 Do I need to incorporate starknetabifromjson?
Implemented core
add testing framework into v0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On line 41 I used a different value than what was used in python test suite due to discrepancy between the expected values in the Go and Python implementations for U256 .