-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement/implement client #57
base: dev
Are you sure you want to change the base?
Conversation
@star-gazer111 pls review |
So u have implemented the entire client module as well as the entire CLI module in this PR? |
No I have implemented only node.go, rpc.go, and errors.go. I had started some part of cli module and client.go |
Can you please create separate PRs out of this?
|
@star-gazer111 @18aaddy picking up cli.go from here |
@18aaddy u can create 2 PRs now from here one involving client.go & the other involving node,rpc & errors. You can remove the commits for CLI module. |
@18aaddy can you rebase your branch please and then make the commits. Else it's leading to a merge conflict. |
1c26a55
to
0d9647e
Compare
0d9647e
to
e79e0dc
Compare
Done |
@18aaddy , I dont think this PR has been split yet |
@gerceboss Should I split it now or wait till rest of files in execution are merged because I'll need to update this PR then anyway as Client depends on execution |
wait for other PRs first |
Resolves #38
The cli folder and client.go are also there because I had started working on them beforehand