Explicit change #40
Open
Explicit change #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkauffman1
force-pushed
the
explicit-change
branch
2 times, most recently
from
b505004 to
1cf2c77
Compare
jgriffiths
reviewed
Apr 28, 2021
| if txhash == '*' or txhash == utxo['txhash']: | ||
| if not pt_idx or pt_idx == '*' or int(pt_idx) == utxo['pt_idx']: | ||
| if txhash == '*' or txhash == 'all' or txhash == utxo['txhash']: | ||
| if not pt_idx or pt_idx == 'all' or pt_idx == '*' or int(pt_idx) == utxo['pt_idx']: |
There was a problem hiding this comment.
nit: comparing in the same order would read better, or perhaps a utility function _is_all could be used.
|
utack 0efc2c9 |
jkauffman1
force-pushed
the
explicit-change
branch
from
0efc2c9 to
db13217
Compare
jkauffman1
force-pushed
the
explicit-change
branch
2 times, most recently
from
da4f257 to
57417c5
Compare
Asterisks are not entirely convenient for a cli
For example: $ green-cli tx outputs add $ADDR change Allows specifying a single explicit change output that will act as a sink for any amount left over after paying the other outputs and fee. In the absence of an explicit change output the gdk will generate a single change output.
jkauffman1
force-pushed
the
explicit-change
branch
from
57417c5 to
1536bc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.