Updated electrum config to support socks5 & validate_domain #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
RCasatta
reviewed
Oct 15, 2024
There was a problem hiding this comment.
Sorry I forgot about this one...
I think we need some refactors tough, there are some issues:
- some parameters are passed in new, some in build_client...
- the comment about retry value
- We can probably use directly
electrum_client::Configinstead of havingElectrumOptions
We can probably go ahead with this (after fixing the retry) and think about the other issues later
| @@ -113,7 +119,10 @@ impl Debug for ElectrumClient { | |||
|
|
|||
| #[derive(Default)] | |||
| pub struct ElectrumOptions { | |||
| timeout: Option<u8>, | |||
| pub timeout: Option<u8>, | |||
| pub retry: u8, | |||
There was a problem hiding this comment.
This as default would be 0, but in electrum_client::Config the default is 1 (not sure what happens with 0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.