Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoL Changes #280

Merged
merged 32 commits into from
Sep 9, 2023
Merged

QoL Changes #280

merged 32 commits into from
Sep 9, 2023

Conversation

NotGeri
Copy link
Member

@NotGeri NotGeri commented Aug 19, 2023

This PR includes the changes from #246 and #255

Here are the main changes:

  • Use medium-zoom for nicer image viewing
  • Update to the latest Docosaurus version
  • Fix not found page
  • Fix header image being low quality
  • Fix light theme sidebar colours being incorrect
  • Simplify document pages
    • Use the regular markdown image syntax
    • Make the header title / image part of the component from the frontmatter
  • Fix up/add a nicer docs overview page
  • Merge README.md & CONTRIBUTING.md

Closes:

@github-actions
Copy link

github-actions bot commented Aug 19, 2023

✔ Verified embeds.yml!

YAML Checker

@NotGeri NotGeri mentioned this pull request Aug 19, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 19, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5b15d8e
Status:⚡️  Build in progress...

View logs

Copy link
Contributor

@zax71 zax71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only other comment I have is that alt text should be added on quite a few of the images

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@NotGeri
Copy link
Member Author

NotGeri commented Sep 8, 2023

Thank you for the review

Only other comment I have is that alt text should be added on quite a few of the images

Yes, I initially wanted to go through and add one for each image, but I think it'll be better as a task on its own

I'll address the rest of these really quick

@NotGeri
Copy link
Member Author

NotGeri commented Sep 9, 2023

Going to merge this now. If anyone sees anything strange, please let me know.

We'll follow up on some more accessibility changes later.

@NotGeri NotGeri merged commit f0026ab into master Sep 9, 2023
@NotGeri NotGeri deleted the feature/qol branch September 9, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants