features around space members #19
Conversation
bob2402
commented
Jun 12, 2024
•
bob2402
commented
- Revise Member Type
bob2402
force-pushed
the
invite-pubkey
branch
2 times, most recently
from
1fb2301 to
4c50e24
Compare
| // create the channel | ||
| const ChannelCreation_event = await sign_event_v2(pri, { | ||
| pubkey: pub, | ||
| const ctx = InMemoryAccountContext.Generate(); |
There was a problem hiding this comment.
Can a private key also implement the signer v2 interface? Just a quesiton for thoughts
There was a problem hiding this comment.
Why do we need to do this?
There was a problem hiding this comment.
We don't have a use case because we rarely direclty use PrivateKey
| const r = await fetch(`${relay.http_url}`, { | ||
| method: "POST", | ||
| body: JSON.stringify(add_member_event), | ||
| }); |
There was a problem hiding this comment.
Let's define a function in nostr.ts to do the same kind of work.
There was a problem hiding this comment.
I can do this when I code for the client tomorrow.
| }); | ||
|
|
||
| await t.step("stranger is not member", async () => { | ||
| const res = await relay.is_space_member(InMemoryAccountContext.Generate().publicKey.hex); |
There was a problem hiding this comment.
In the future, it would be nice if we can have an automatic way to generating REST APIs based on public methods of the relay object so that we always have up to date APIs in both JavaScript and REST.
There was a problem hiding this comment.
Perhaps we don't need to generate it automatically, we can define the interface in nostr.ts and then implement it in the space and client
There was a problem hiding this comment.
That's a better idea. For exampel,
type func_GetSpaceMembers = xxx
is a local function in relayed and a network call in nostr.ts
