Add functions to export feature data to CSV and JSON formats #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/test_io.py
Outdated
| import efel | ||
| import os | ||
| import json | ||
| feature_values = { |
There was a problem hiding this comment.
Are we sure that this is exactly what efel would return? No numpy stuff?
There was a problem hiding this comment.
Also would be interesting to have some null/None values in it (not sure which one to sure exactly, use whatever efel is using)
There was a problem hiding this comment.
Good point, I have switched to using the output from get_feature_values instead and tested with some more traces that have some or all None feature values
Conflicts: efel/settings.py
AurelienJaquier
approved these changes
May 8, 2024
anilbey
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have also eased up on type checking. Now, the system will try to convert the value to the correct type, such as int to float.
Checklist: