Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix impedance freq indexing #407

Merged
merged 3 commits into from
Aug 7, 2024
Merged

fix impedance freq indexing #407

merged 3 commits into from
Aug 7, 2024

Conversation

AurelienJaquier
Copy link
Collaborator

@AurelienJaquier AurelienJaquier commented Aug 7, 2024 •
edited
Loading

Description

We change the indexing of smooth_Z, but forget to also change the indexing of freq when applying a smooth_Z index. This should solve the impedance = 0.0 results that we were getting.

Checklist:

  • Unit tests are added to cover the changes (skip if not applicable).
  • The changes are mentioned in the documentation (skip if not applicable).
  • CHANGELOG file is updated (skip if not applicable).

@AurelienJaquier AurelienJaquier self-assigned this Aug 7, 2024
@AurelienJaquier AurelienJaquier requested a review from ilkilic August 7, 2024 12:16
@AurelienJaquier AurelienJaquier merged commit ff75107 into master Aug 7, 2024
20 checks passed
@AurelienJaquier AurelienJaquier deleted the fix-impedance branch August 7, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilkilic ilkilic ilkilic approved these changes

Assignees

@AurelienJaquier AurelienJaquier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AurelienJaquier @ilkilic