Add mechanism for retrieving BlockEntity data #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBlueF
requested changes
Mar 17, 2024
BlueMapCore/src/main/java/de/bluecolored/bluemap/core/world/block/BlockEntity.java
Outdated
Show resolved
Hide resolved
BlueMapCore/src/main/java/de/bluecolored/bluemap/core/world/block/BlockEntity.java
Outdated
Show resolved
Hide resolved
BlueMapCore/src/main/java/de/bluecolored/bluemap/core/world/block/Block.java
Outdated
Show resolved
Hide resolved
BlueMapCore/src/main/java/de/bluecolored/bluemap/core/world/block/BlockEntity.java
Outdated
Show resolved
Hide resolved
BlueMapCore/src/main/java/de/bluecolored/bluemap/core/world/mca/chunk/Chunk_1_13.java
Outdated
Show resolved
Hide resolved
TBlueF
reviewed
Mar 17, 2024
BlueMapCore/src/main/java/de/bluecolored/bluemap/core/world/mca/chunk/Chunk_1_13.java
Outdated
Show resolved
Hide resolved
glorantq
force-pushed
the
tile-entities
branch
2 times, most recently
from
e92f106 to
213e141
Compare
This commit adds a mechanism for retrieving block entity data. Block entity data is required to support for example text on signs, banner patterns, or mods such as Domum Ornamentum.
TBlueF
reviewed
Mar 19, 2024
BlueMapCore/src/main/java/de/bluecolored/bluemap/core/world/block/entity/BlockEntity.java
Outdated
Show resolved
Hide resolved
BlueMapCore/src/main/java/de/bluecolored/bluemap/core/world/mca/chunk/Chunk_1_13.java
Outdated
Show resolved
Hide resolved
This commit fixes the incorrect shifting of bits when packing the chunk-local coordinates of a block entity into a 64-bit long for lookups.
This commit changes the type stored for BlockEntity mappings from a class of the type associated with the ID to a method reference to its constructor.
This commit introduces a small functional interface to make the type less ungodly. Also silences the warning about referencing subclasses in the superclass, it is fine in this case, we're just storing a reference to the constructor.
|
The github-build fails, but i think it only needs a |
The license headers were missing. Oops.
|
Yeah I realised I missed the headers, should be fine now. |
TBlueF
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a mechanism for retrieving block entity data. Block entity data is required to support for example text on signs, banner patterns, or mods such as Domum Ornamentum.