Skip to content

Commit

Permalink
Code-style improvements, fixed typos and version push
Browse files Browse the repository at this point in the history
  • Loading branch information
TBlueF committed Oct 3, 2020
1 parent 7069a1c commit 17cbf15
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 8 deletions.
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
org.gradle.jvmargs=-Xmx3G
org.gradle.daemon=false

apiVersion=1.3.0
apiVersion=1.3.1
6 changes: 3 additions & 3 deletions src/main/java/de/bluecolored/bluemap/api/BlueMapAPI.java
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ public abstract class BlueMapAPI {
private static BlueMapAPI instance;

@Deprecated
private static Collection<BlueMapAPIListener> listener = new ArrayList<>(2);
private static final Collection<BlueMapAPIListener> listener = new ArrayList<>(2);

private static Collection<Consumer<BlueMapAPI>> onEnableConsumers = new ArrayList<>(2);
private static Collection<Consumer<BlueMapAPI>> onDisableConsumers = new ArrayList<>(2);
private static final Collection<Consumer<BlueMapAPI>> onEnableConsumers = new ArrayList<>(2);
private static final Collection<Consumer<BlueMapAPI>> onDisableConsumers = new ArrayList<>(2);

/**
* Getter for the {@link RenderAPI}.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
*/
package de.bluecolored.bluemap.api;

import java.util.function.Consumer;

/**
* @deprecated Implementing {@link BlueMapAPIListener} can cause a ClassNotFoundException when you soft-depend on BlueMap and your plugin/mod gets used without BlueMap.
* Use {@link BlueMapAPI#onEnable(Consumer)} and {@link BlueMapAPI#onDisable(Consumer)} instead.
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/de/bluecolored/bluemap/api/marker/Marker.java
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ public interface Marker {
void setLabel(String label);

/**
* Gets the link-adress of this {@link Marker}.<br>
* Gets the link-address of this {@link Marker}.<br>
* If a link is present, this link will be followed when the user clicks on the marker in the web-app.
*
* @return the {@link Optional} link
Expand All @@ -133,7 +133,7 @@ public interface Marker {
boolean isNewTab();

/**
* Sets the link-adress of this {@link Marker}.<br>
* Sets the link-address of this {@link Marker}.<br>
* If a link is present, this link will be followed when the user clicks on the marker in the web-app.
*
* @param link the link, or <code>null</code> to disable the link
Expand Down
11 changes: 9 additions & 2 deletions src/main/java/de/bluecolored/bluemap/api/marker/MarkerSet.java
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,22 @@ public interface MarkerSet {
* @param toggleable whether this {@link MarkerSet} should be toggleable
*/
void setToggleable(boolean toggleable);


/**
* @deprecated method name has a typo, use {@link #isDefaultHidden()} instead.
*/
default boolean isDefautHidden() {
return isDefaultHidden();
}

/**
* Checks if this {@link MarkerSet} is hidden by default.
* <p>This is basically the default-state of the toggle-button from {@link #isToggleable()}. If this is <code>true</code> the markers of this marker set will initially be hidden and can be displayed using the toggle-button.</p>
*
* @return whether this {@link MarkerSet} is hidden by default
* @see #isToggleable()
*/
boolean isDefautHidden();
boolean isDefaultHidden();

/**
* Sets if this {@link MarkerSet} is hidden by default.
Expand Down

0 comments on commit 17cbf15

Please sign in to comment.