Skip to content

Commit

Permalink
Fix typo.
Browse files Browse the repository at this point in the history
(Yes this is a breaking change, i don't care, no one uses this yet, and if they do they should have told me!)
  • Loading branch information
TBlueF authored Aug 19, 2022
1 parent d351b1f commit f8d10d1
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ public int hashCode() {
* Creates a Builder for {@link POIMarker}s.
* @return a new Builder
*/
public static Builder toBuilder() {
public static Builder builder() {
return new Builder();
}

Expand Down

2 comments on commit f8d10d1

@SkytAsul
Copy link

@SkytAsul SkytAsul commented on f8d10d1 Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When doing this, please let the original method as deprecated so it won't break backward-compatibility 😭

EDIT: woops my bad, haven't seen the next commit.

@TBlueF
Copy link
Member Author

@TBlueF TBlueF commented on f8d10d1 Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SkytAsul
Already done, don't worry ^^

This commit was right after the first release .. since it took a long time to push a new release with this change, i decided to not do a breaking change :)

See: 4831537

Please sign in to comment.