Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructuring headers and updating makevars in R-package #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Blunde1
Copy link
Owner

@Blunde1 Blunde1 commented Oct 1, 2019

Header files are base C++, which distributions in R, Py, Java, ... will read from. They should be located under root, not under R-package

@Blunde1
Copy link
Owner Author

Blunde1 commented Oct 2, 2019

Cannot find header files during installation from GitHub. Asked question https://stackoverflow.com/q/58189830/7456798 on stackoverflow.

@Blunde1
Copy link
Owner Author

Blunde1 commented Oct 2, 2019

Works with travis: dependent upon

before_install:
 - cp -r inst/include R-package/include
 - cd R-package

and modifying Makevars accordingly.

Will still fail with devtools::install_github

Do not merge pull-request before functional with above function or on CRAN (or some other easy way to install).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant