BLZT-49 adding some logs #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bring into BLZT-49 # Conflicts: # core/src/main/java/com/bobocode/bring/core/context/impl/AnnotationBringBeanRegistry.java # core/src/main/java/com/bobocode/bring/core/context/impl/BringApplicationContext.java # core/src/main/java/com/bobocode/bring/core/context/impl/DefaultBringBeanFactory.java # web/src/main/java/com/bobocode/bring/web/BringWebApplication.java
PolukovY
reviewed
Nov 26, 2023
| @@ -74,7 +74,7 @@ private void invokeTaskMethod(Object bean, Method method, String taskName) { | |||
| try { | |||
| method.invoke(bean); | |||
| } catch (Exception exe) { | |||
| log.error("Cannot invoke taskName [" + taskName + "] error " + exe.getMessage(), exe); | |||
There was a problem hiding this comment.
Need update test logback-test.xml add trace by default
PolukovY
reviewed
Nov 26, 2023
| @@ -55,5 +58,6 @@ public void handleAnnotation(Object instance, Method method, String requestMappi | |||
| .orElse(new ArrayList<>()); | |||
| addSorted(params, getMethodParamsList); | |||
| restControllerParamsMap.put(RequestMethod.GET.name(), getMethodParamsList); | |||
| log.info(""); | |||
There was a problem hiding this comment.
Add some text or remove it.
andrewpikozh
requested review from
PolukovY,
romanovosad87,
mvorotniak,
Ivan95kos and
proyalko
Closed
…bring into BLZT-49 # Conflicts: # core/src/main/java/com/bobocode/bring/core/context/impl/DefaultBringBeanFactory.java
Ivan95kos
approved these changes
Nov 29, 2023
…bring into BLZT-49 # Conflicts: # core/src/main/java/com/bobocode/bring/core/context/impl/BeanCreator.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.