Search facets filters #896
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbfsdev
force-pushed
the
search-facets-filters
branch
3 times, most recently
from
bd5c263 to
ae20678
Compare
bbfsdev
force-pushed
the
search-facets-filters
branch
4 times, most recently
from
6382c4d to
2f45209
Compare
davgur
reviewed
Jul 17, 2022
|
|
||
| const ContentType = ({ namespace, t }) => { | ||
| let items = useSelector(state => selectors.getTree(state.filtersAside, namespace, FN_CONTENT_TYPE)); | ||
| // console.log('ContentType filter items', items) |
davgur
reviewed
Jul 17, 2022
| @@ -83,6 +83,10 @@ const FallbackImage = props => { | |||
| } | |||
|
|
|||
| if (knownFallbackImages.includes(imageSource)) { | |||
There was a problem hiding this comment.
fluid is semantic prop so for not semantic components its not need ( I was remove 'circle' so)
There was a problem hiding this comment.
I'm fixing the following error:
There was a problem hiding this comment.
Removed this code from this PR.
bbfsdev
force-pushed
the
search-facets-filters
branch
4 times, most recently
from
ada6250 to
091640c
Compare
bbfsdev
force-pushed
the
search-facets-filters
branch
from
091640c to
131d8f5
Compare
davgur
reviewed
Aug 3, 2022
| @@ -35,6 +35,8 @@ const TagSourceItem = props => { | |||
| const getById = isTag ? getTagById : getSourceById; | |||
| const item = getById(id); | |||
| const childrenIDs = useMemo(() => item.children?.filter(x => baseItems.includes(x)) || [], [baseItems, item]); | |||
| const childrenStats = useSelector(state => filtersAside.getMultipleStats(state.filtersAside, namespace, filterName)(childrenIDs)); | |||
There was a problem hiding this comment.
you run it for all pages even you need it for search only
davgur
reviewed
Aug 3, 2022
| const baseItems = useSelector(state => selectors.getTree(state.filtersAside, namespace, FN_TOPICS_MULTI)); | ||
| const selectedFilters = useSelector(state => filters.getFilterByName(state.filters, namespace, FN_TOPICS_MULTI)); | ||
| const selected = useMemo(() => selectedFilters?.values || [], [selectedFilters]); | ||
|
|
||
| console.log('SELECTED', selected); |
davgur
reviewed
Aug 3, 2022
| @@ -59,12 +70,23 @@ const receiveSingleTypeStats = createAction(RECEIVE_SINGLE_TYPE_STATS); | |||
| const fetchStatsFailure = createAction(FETCH_STATS_FAILURE); | |||
| const receiveLocationsStats = createAction(RECEIVE_LOCATIONS_STATS); | |||
|
|
|||
| const fetchElasticStats = createAction(FETCH_ELASTIC_STATS, (namespace, params, isPrepare) => ({ | |||
There was a problem hiding this comment.
I think you dont need isPrepare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.