Skip to content

Commit

Permalink
tcpreplay: Fix CVE-2023-4256
Browse files Browse the repository at this point in the history
Add patch to fix tcpreplay CVE-2023-4256
dlt_jnpr_ether_cleanup: check config before cleanup
Links:
appneta/tcpreplay#851
appneta/tcpreplay#813 (comment)

Signed-off-by: Poonam Jadhav <[email protected]>
Signed-off-by: Armin Kuster <[email protected]>
  • Loading branch information
PoonamPJadhav authored and akuster committed Jul 30, 2024
1 parent 4052c97 commit e488bc8
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
From 62bc10d4f1d2c9e2833ef2898fb0170e9300a9dd Mon Sep 17 00:00:00 2001
From: Marsman1996 <[email protected]>
Date: Tue, 2 Apr 2024 17:29:21 +0800
Subject: [PATCH] dlt_jnpr_ether_cleanup: check config before cleanup

CVE: CVE-2023-4256
Upstream-Status: Backport [https://github.com/appneta/tcpreplay/pull/851]
Signed-off-by: Poonam Jadhav <[email protected]>
---
src/tcpedit/plugins/dlt_jnpr_ether/jnpr_ether.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/tcpedit/plugins/dlt_jnpr_ether/jnpr_ether.c b/src/tcpedit/plugins/dlt_jnpr_ether/jnpr_ether.c
index c53ec297..9642a2c2 100644
--- a/src/tcpedit/plugins/dlt_jnpr_ether/jnpr_ether.c
+++ b/src/tcpedit/plugins/dlt_jnpr_ether/jnpr_ether.c
@@ -164,8 +164,9 @@ dlt_jnpr_ether_cleanup(tcpeditdlt_t *ctx)
jnpr_ether_config_t *config;

config = (jnpr_ether_config_t *)ctx->encoder->config;
- if (config->subctx != NULL)
+ if (config != NULL && config->subctx != NULL) {
tcpedit_dlt_cleanup(config->subctx);
+ }
safe_free(plugin->config);
plugin->config = NULL;
plugin->config_size = 0;
4 changes: 3 additions & 1 deletion meta-networking/recipes-support/tcpreplay/tcpreplay_4.4.4.bb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ SECTION = "net"
LICENSE = "GPL-3.0-only"
LIC_FILES_CHKSUM = "file://docs/LICENSE;md5=10f0474a2f0e5dccfca20f69d6598ad8"

SRC_URI = "https://github.com/appneta/tcpreplay/releases/download/v${PV}/tcpreplay-${PV}.tar.gz"
SRC_URI = "https://github.com/appneta/tcpreplay/releases/download/v${PV}/tcpreplay-${PV}.tar.gz \
file://CVE-2023-4256.patch \
"

SRC_URI[sha256sum] = "44f18fb6d3470ecaf77a51b901a119dae16da5be4d4140ffbb2785e37ad6d4bf"

Expand Down

0 comments on commit e488bc8

Please sign in to comment.