Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPM Support #347

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

SPM Support #347

wants to merge 6 commits into from

Conversation

drdaz
Copy link

@drdaz drdaz commented May 20, 2021

Adds SPM support.

This is my first work with SPM; it seems like it has great potential, but is currently limited. I couldn't find a practical way to have iOS-specific files not compile for macOS with the manager, so there's some sad precompiler work in the iOS-specific files.

@facebook-github-bot
Copy link
Contributor

Hi @drdaz!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@drdaz drdaz marked this pull request as draft May 20, 2021 12:12
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@drdaz drdaz marked this pull request as ready for review May 21, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants