Cam #1
Open
Cam #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: For quadracfa capture, Blob/YUV output streams need to be configured with custom dimensions which will not be available in advertised stream configurations map. Fix: Skip the stream size check for whitelisted apps to allow configuration of streams with custom dimensions. Setprop to be used: adb shell setprop persist.vendor.camera.privapp.list <pack1,pack2> Change-Id: Id94b40c94f42bf4579dc6d8bb6273003312ea669 Signed-off-by: Joey Huab <[email protected]>
write camera package name if matches Change-Id: Ia84d5f7f3961945e2143968eb572f5d9106d0297 libcameraservice: write all pkgNames Change-Id: I85c2e9d4ffb56cc08aea1c1eabc1ed2ec45c0217 Signed-off-by: Joey Huab <[email protected]>
Change-Id: I0d244b81625fd9514000bea313a28ad60321333f Signed-off-by: Joey Huab <[email protected]>
*This fixes the torch light for cameras with hal 1
*This fix works on the htc m7ul
*Fixed line length
*Fixed unused parameter names
[AdrianDC]
* Adapt for 8.0.0 by adding dataCallbackTimestampBatch with
matching data_callback_timestamp_batch function signature
Change-Id: I89c6112546e36dbcca099f4d5cd70371b2c5340a
(cherry picked from commit 3f6bb688b22b184b0bfc2739cda3c3cf0dd06a14)
Signed-off-by: Adrian DC <[email protected]>
Signed-off-by: Kshitij Gupta <[email protected]>
Signed-off-by: DennySPB <[email protected]>
Signed-off-by: Joey Huab <[email protected]>
…ndor listeners. Fixes regression caused by aosp/1152176, status update callbacks were being skipped for non HAL3 devices for non vendor listeners. Non vendor listeners should still get callbacks in case of non HAL3 devices. Bug: 150180641 Test: Camera2 App Test: CTS Test: Use vendor clients of cameraserver Test: Vendor testing Merged-In: Ic31f71887b55f3d838ca35274a5f65802ea50584 Change-Id: Ifab0be4dac4b42f6923ce48ab57aeb0aaf26575b Signed-off-by: Jayant Chowdhary <[email protected]> (cherry picked from commit edfb260) Signed-off-by: Joey Huab <[email protected]>
Change-Id: I39c59065b1c4e1a1995c755ab490f23407db1da6
|
Don't merge now. Will Add more commits to vendor,fwb. |
eldainosor
pushed a commit
that referenced
this pull request
Mar 23, 2023
Do not hold lock when IPC call is expected from HAL. C2SurfaceSyncObj is shared lock between framework and HAL. HAL process can have only one thread to handle IPC from HAL to framework. Therefore Holding C2SurfaceSyncObj from HAL during IPC call could trigger deadlock. The exact scenario is as follows. Thread #1:(HAL -> framework IPC) HIDL call onInputBuffersReleased() calls to feedInputBufferIfAvailable(). Since this is using HAL IPC thread, this will block Thread #3. This is waiting for mOuput mutex which is held by Thread #2. Thread #2:(framework) discardBuffer() holds mOutput mutex which blocks Thread #1. But this is waiting for C2SurfaceSyncObj which is held by Thread #3. Thread #3:(HAL) Dtor of C2BufferQueueBlockPoolData is holding C2SurfaceSyncObj, therefore this will block #2. This thread is waiting for HIDL IPC thread to be free in order for 'igbp->cancel()', but HIDL IPC thread is already occupied by Thread #1. Bug: 246707566 Test: atest android.media.decoder.cts.AdaptivePlaybackTest Test: atest android.media.decoder.cts.DecoderTest Change-Id: I6a9540d3b4d03806cd40bb4f89a234a6b77758a9 Merged-In: I6a9540d3b4d03806cd40bb4f89a234a6b77758a9
tribual
pushed a commit
that referenced
this pull request
Dec 30, 2023
Log: --------- beginning of crash 09-08 18:41:01.397 1119 1119 F libc : Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 1119 (vendor.qti.medi), pid 1119 (vendor.qti.medi) 09-08 18:41:01.502 1183 1183 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** 09-08 18:41:01.502 1183 1183 F DEBUG : Build fingerprint: 'Redmi/sweet_eea/sweet:13/RKQ1.210614.002/V14.0.5.0.TKFEUXM:user/release-keys' 09-08 18:41:01.502 1183 1183 F DEBUG : Revision: '0' 09-08 18:41:01.502 1183 1183 F DEBUG : ABI: 'arm64' 09-08 18:41:01.502 1183 1183 F DEBUG : Timestamp: 1972-09-08 22:41:01.460993955+0000 09-08 18:41:01.502 1183 1183 F DEBUG : Process uptime: 2s 09-08 18:41:01.502 1183 1183 F DEBUG : Cmdline: /vendor/bin/hw/[email protected] 09-08 18:41:01.502 1183 1183 F DEBUG : pid: 1119, tid: 1119, name: vendor.qti.medi >>> /vendor/bin/hw/[email protected] <<< 09-08 18:41:01.502 1183 1183 F DEBUG : uid: 1046 09-08 18:41:01.502 1183 1183 F DEBUG : signal 6 (SIGABRT), code -1 (SI_QUEUE), fault addr -------- 09-08 18:41:01.502 1183 1183 F DEBUG : Abort message: 'Could not read base policy file '/vendor/etc/seccomp_policy/codec2.vendor.base-arm64.policy'' 09-08 18:41:01.502 1183 1183 F DEBUG : x0 0000000000000000 x1 000000000000045f x2 0000000000000006 x3 0000007feb8eb770 09-08 18:41:01.502 1183 1183 F DEBUG : x4 1f646b68651f7862 x5 1f646b68651f7862 x6 1f646b68651f7862 x7 7f7f7f7f7f7f7f7f 09-08 18:41:01.502 1183 1183 F DEBUG : x8 00000000000000f0 x9 000000000000045f x10 ffffff80ffffffdf x11 fffffffffffffffd 09-08 18:41:01.502 1183 1183 F DEBUG : x12 0000007feb8eb6e0 x13 000000000000005d x14 b400007b592708d0 x15 0000000000001556 09-08 18:41:01.502 1183 1183 F DEBUG : x16 0000007c44d34d30 x17 0000007c44d0ed80 x18 0000007c4c334000 x19 000000000000045f 09-08 18:41:01.502 1183 1183 F DEBUG : x20 000000000000045f x21 00000000ffffffff x22 0000007c4b94e000 x23 0000000000000000 09-08 18:41:01.502 1183 1183 F DEBUG : x24 0000007c4b94e000 x25 0000000000000000 x26 0000000000000000 x27 0000000000000000 09-08 18:41:01.502 1183 1183 F DEBUG : x28 0000000000000000 x29 0000007feb8eb7f0 09-08 18:41:01.502 1183 1183 F DEBUG : lr 0000007c44cb3af8 sp 0000007feb8eb750 pc 0000007c44cb3b28 pst 0000000000000000 09-08 18:41:01.502 1183 1183 F DEBUG : 7 total frames 09-08 18:41:01.502 1183 1183 F DEBUG : backtrace: 09-08 18:41:01.502 1183 1183 F DEBUG : #00 pc 000000000005cb28 /apex/com.android.runtime/lib64/bionic/libc.so (abort+168) (BuildId: c93d1a140ae4309e1fe245f371b65776) 09-08 18:41:01.502 1183 1183 F DEBUG : #1 pc 000000000000650c /system/lib64/liblog.so (__android_log_default_aborter+12) (BuildId: 4fedcd06dc017905f90f4867f88f7fb1) 09-08 18:41:01.502 1183 1183 F DEBUG : #2 pc 00000000000b5560 /apex/com.android.vndk.v34/lib64/libbinder.so (android::base::LogMessage::~LogMessage()+352) (BuildId: ecaf8d435fefbfb6b8ead7955216105b) 09-08 18:41:01.502 1183 1183 F DEBUG : #03 pc 0000000000002b38 /vendor/lib64/libavservices_minijail.so (android::SetUpMinijailList(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) (.cfi)+968) (BuildId: 8e383a241e9281b774145759dc5cf604) 09-08 18:41:01.502 1183 1183 F DEBUG : #04 pc 0000000000002718 /vendor/lib64/libavservices_minijail.so (android::SetUpMinijail(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) (.cfi)+88) (BuildId: 8e383a241e9281b774145759dc5cf604) 09-08 18:41:01.502 1183 1183 F DEBUG : #05 pc 0000000000002120 /vendor/bin/hw/[email protected] (main+204) (BuildId: 0657e5d9e535ccf550dc5e12ef6974a1) 09-08 18:41:01.502 1183 1183 F DEBUG : #06 pc 0000000000054f08 /apex/com.android.runtime/lib64/bionic/libc.so (__libc_init+104) (BuildId: c93d1a140ae4309e1fe245f371b65776) 09-08 18:41:02.294 1399 1399 F linker : CANNOT LINK EXECUTABLE "/vendor/bin/hw/[email protected]": cannot locate symbol "_ZN7android19GraphicBufferSource9configureERKNS_2spINS_16ComponentWrapperEEEiijjj" referenced by "/vendor/lib/vndk/libstagefright_omx.so"... Change-Id: Iee237e289867cfec2863eafbbc5f76de09ccc61c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.