FOD Improvements and some other goodies #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- include <sys/uio.h> in order to resolve use of undeclared identifier 'writev' - implement abstract methods for QC value-adds on BaseWifiService - update files to match in specs in api/current.txt and api/system-current.txt - media/jni/Android.bp needed a static dependency moved to shared object dependency Bug: 123699636 Change-Id: I30f97e24e83274016e720548fba412da0f35c98f
Use case: Open any app that performs advertising. Expected result: BLE should Start advertisement. Observed result : Observed force close in BA App. Fix: set zero into parcel if transport discovery data is empty. Test: BLE Start advertisement successes after performing above use case. CRs-Fixed: 2304532 Change-Id: Ica730f8d22367864308412621a8d87e625198bec
Keep track of active TWS+ EB device in MM Audio module based on device connect/disconnect events as part of Active device update. This device tracking will help us to make decision for Audio updates regarding reconfig should be done OR not based on EBs transition use-case. CRs-Fixed: 2717923 Change-Id: I2df8447acb1d8e1b843a49906f2f3e3993dee5d6
Update key of bt-a2dp inside mApmConnectedDevices when the active bt device changes. CRs-Fixed: 2634767 Change-Id: I92fa39581a10fd8900e41139d71ca46dd2445eb6
When disconnecting BT device, BT device state machine may be destroyed and cause query of codec failed. This can make device disconnection failed in low layer audio service. CRs-Fixed: 2604724 Change-Id: I970802310eae0b5b43340aaddb312906e1a4c444
- Disconnecting and clearing Bluetooth Profiles during Turning Off State doesn't give chance to A2DP/AVRCP profiles to save and retain Audio related data like Volume level. - This change ensures Audio Service only disconnect Bluetooth Profile on receiving Bluetooth Off state. Change-Id: Ie99cb2b35b9ddc7e4f0d0f89407cda9641379fb8 CRs-Fixed: 2512169
Add callback onA2dpCodecConfigChanged for intent BluetoothA2dp.ACTION_CODEC_CONFIG_CHANGED. Change-Id: I4d19f0427c2f68dfd01a241eb631c6782d948395 CRs-Fixed: 2735935
Add APTX-Adaptive and APTX-TWS+ entires to bluetooth a2dp codec summaries w.r.t major languages. CRs-Fixed: 2778223 Change-Id: Ia8ce5099a4247cf2e84978e9cfb2ee18864a71d7
Add support for lc3 codec. CRs-Fixed: 2789473 Change-Id: Ica900e6546642e8c945170645f129e3a83301ddd
- Add LC3 codec type - Add additional sample rate and channel mode CRs-Fixed: 2789473 Change-Id: I13d0c6944a12422c13e2069697817c0f26330179
Bug: 172841550 Test: manual Change-Id: I1a16808426934f4a8d12410576d769443e4c2a04 Merged-In: I3cd5a94386f15cf60a7fe3095b00815e4a6485ae (cherry picked from commit 6ff42dd)
…2, 13320131, 13320074, 13320075, 13321410, 13320132, 13319972, 13320076, 13320077, 13320353, 13320354] into rvc-qpr2-release Change-Id: I37d394a571a5a6c5775fffa81f855e1157042d5f
…5, 13351986, 13351113, 13351104] into rvc-qpr2-release Change-Id: Ia2ac25ec8b825b233db12470b7905592c1ec94ac
Bug: 169758206 Test: manual Change-Id: I98ac9eecd8a497541d9ce0761920db1252eb72e0 Merged-In: I98ac9eecd8a497541d9ce0761920db1252eb72e0 (cherry picked from commit 2268caf)
…8] into rvc-qpr2-release Change-Id: I931e82213d5ef58422f8dcd4980db4d6d0f9a1fb
Bug: 174243830 Test: manual Change-Id: I2f81bcd57181791fa95d35ad52e6af2d7d9c8dcf Merged-In: If305a4b694a9d6fcc27da8279f1f53f9fd9cb685 Merged-In: I345d9ff828021da35556f2d51da512840dda8026 (cherry picked from commit 557838f)
Bug: 177561690 Test: on device Change-Id: Icafbdf54fe807f8779377b13cb4e4eb265db692e (cherry picked from commit abccd8f)
Auto verification of app links requires that an intent filter declare action=VIEW, scheme=HTTP(S), category=BROWSABLE. However, PackageManagerService was not taking that into account, missing the category requirement. But the app info Settings UI did take category into account, so it was possible for a user to set an application to automatically open web URIs without understanding that this also granted domains that were not visible in the app info UI. To resolve both this, this change makes it so that both auto verification and the Settings state can only consider the app as "always" open only if the Intent contains both BROWSABLE and DEFAULT. Bug: 175139501 Bug: 175319005 Test: manual, see bug for reproduction steps Merged-In: Ib957258735893bf2779bed19bd400c6726ee6478 Change-Id: Ib957258735893bf2779bed19bd400c6726ee6478 (cherry picked from commit 4266f93) (cherry picked from commit 0f337fc)
This makes sure the write operation (NativeInputApplicationHandle ::updateInfo) is always called from window manager side once when calling SurfaceControl.Transaction#setInputWindowInfo or InputManagerService#setFocusedApplication. If the info of input application handle is changed, a new instance will be created. That avoids the race condition of reading the fields of the same InputApplicationInfo instance from input dispatcher. Bug: 171857140 Bug: 161334769 Bug: 174768985 Test: WindowInputTests Merged-In: Ief84bbe6e6fa4da5309912059904932ccf775b75 Merged-In: I70de9835c7699fe6f56fc3655b0fee5c317ecc3a Change-Id: I70de9835c7699fe6f56fc3655b0fee5c317ecc3a (cherry picked from commit a68473c)
mUidFieldIndex, mExclusiveStateFieldIndex,
mAttributionChain{Start|End}Index are stored using int8_t.
These values can overflow when mValues.size() exceeds INT8_MAX.
Add proper bounds checking to ensure these values don't exceed
INT8_MAX.
Bug: 174488848
Bug: 174485572
Test: m
Test: statsd_test
Test: TreeHugger
Change-Id: I416e2de06ca2935017e15d4e91000652831e6b6c
(cherry picked from commit 53251a4)
As per requested in b/176940932#comment3 and b/156260178#comment32, extending the valid font size scale range to [0.25, 5]. Existing CTS tests still pass. BUG: 156260178 Test: atest android.provider.cts.settings.Settings_SystemTest Test: atest android.app.cts.ApplicationTest Change-Id: Icff82d727d63da4353342b0f9a5ca3c2ae1671c1 (cherry picked from commit df8852a) Merged-In: Icff82d727d63da4353342b0f9a5ca3c2ae1671c1 (cherry picked from commit bd6fc82)
Historically, we havent held a lock on ForceClearCache and ClearCacheIfNecessary. This is not thread safe because kAllPullAtomInfo must be accessed in a lock, especially now that pullers can be registered/unregistered. Test: atest statsd_test, wrote a repro cl. Bug: 168156854 Bug: 173552790 Change-Id: I47d53a6d9d274bca4c78dbfd87e0097091b7b8cb Merged-In: I47d53a6d9d274bca4c78dbfd87e0097091b7b8cb Merged-In: I8bee7a0a6acecc1274d5acc0adb44c5dde8862e4 (cherry picked from commit f9a4bb1) (cherry picked from commit db09721)
Prevent non-system overlays from showing over CDM UI Since CDM grants privileges, it should have the same overlay policy as permission UI Test: use an app wit ha visible overlay to ensure the overlay disappears when CDM is shown Fixes: 171221090 Change-Id: I004843edf5a156dc07fb961edf80272f5cb50163 (cherry picked from commit ea4ce4d) (cherry picked from commit 3c2fece)
Allow CDM to hide overlays Since CDM has sensitive user consent UIs, it should be able to hide non-system overlays Test: use a 3p overlay app with a visible overlay to ensure overlay disappears when CDM is shown Bug: 171221090 Change-Id: I78673b7b95f4c3cb31fab180201eb17c9123bddf Merged-In: I78673b7b95f4c3cb31fab180201eb17c9123bddf (cherry picked from commit 43e8c61)
Currently, we keep the process up even if the user switches, meaning that in some cases (if the user is switched while the screenshot UI is up) we will save images to the wrong profile. This change makes ScreenshotHelper listen for user switches and close the screenshot service, so that a new screenshot is guaranteed to be constructed with the correct user's context. Bug: 170474245 Fix: 170474245 Test: manual -- verified bad state occurs if user switches within the timeout period, ensured that screenshots work immediately after switching with this change. Change-Id: I9d32d0928e6c2bda161d04555438d0dd7afef0ba (cherry picked from commit 7ef1a5d) (cherry picked from commit 05f7aef)
…9, 13524930, 13522744, 13524951, 13524860, 13524371, 13524372, 13524373, 13524374, 13524861, 13525166, 13525167, 13525168, 13524843, 13524957, 13524958, 13524936, 13525246, 13524939, 13524940, 13525248, 13524942, 13525249, 13525250, 13525251, 13524943, 13525169, 13525170, 13524358, 13524961, 13524962, 13524963, 13524966, 13524844, 13525325, 13525326, 13524964, 13525327, 13525328, 13524359, 13525307, 13525345] into rvc-qpr2-release Change-Id: I8328acedee0dc20031cf42c924d42c1b623d3ce9
Use ApplicationInfoAsUser() to get the application information by
user id to make sure we have correct permission, othewise we will
get the SecurityException due to lack of INTERACT_ACROSS_USERS.
Bug: 176313819
Test: atest CtsVoiceRecognitionTestCases
Test: manual.
1.create profile user
2.Install sample recognizer app
3.Function works fine and no security exception occurred after
apply the change
Change-Id: I6958dbf661373606fb9dba55e386aaea4399a146
Merged-In: Iaf485537b8082d2109d2134ff987dc7244e31218
(cherry picked from commit d96bcfc)
This test checks that if a VPN declares an underlying network that does not exist, the capabilities of that network are applied to the VPN as soon as the network starts to exist. Bug: 172870110 Test: test-only change Change-Id: Icc0701cb4cea7d91f7738c1e426e94cd26686b74 Merged-In: Icc0701cb4cea7d91f7738c1e426e94cd26686b74 (cherry picked from commit a21b225)
Android has been fine with a slightly less obnoxious emergency tile in global actions for many years before this was introduced. The new tile is too vibrant and distracts the user from other "normal" tiles in the global actions view, despite being used much less frequently than them. This removes the emergency tile's special background color and reduces the saturation of its red color for better contrast with the default dark tile background color. Change-Id: Iab055475e44451dd81d4d126fe7d2a4bbbaf386e
Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: spezi77 <[email protected]>
Instead of abusing ImageView, which is not meant to be an interactive widget, use ImageButton for the auto-brightness toggle. This allows us to make it consistent with the rest of the UI by playing a ripple animation on interaction. It should also improve accessibility by being more semantically accurate. To remove ImageButton's default background, border, and padding while keeping the ripple effect, Change-Id: I8814714c309e43842a1e55b722333015e185ff4b Signed-off-by: spezi77 <[email protected]>
Specifying the blur radius in pixels leads to inconsistent results across devices with different pixel densities. With a Pixel 4 XL (1440x3040) as the reference display (3.5x scale factor), 175 px is more or less the amount of blur we want, but it's too strong on the Pixel 5 (1080x2340). Define the blur radius in device-independent pixels (calculated from the reference display described above) to make the strength uniform. Change-Id: I3295282de81389cc863d63d58370febaf16a0623 Signed-off-by: spezi77 <[email protected]>
Was broken after r33 merge (see 62a3a83) Also no reason to register the same observers twice google Change-Id: I909b421fc22e8c35883d38f1a70f63085a229b49 Signed-off-by: spezi77 <[email protected]>
Signed-off-by: spezi77 <[email protected]>
[spezi77 edit] Unlike in the commit by Lucchetto useQsMediaPlayer() should not be called with a null context because it would crash our system. Therefore completely remove the useQsMediaPlayer() check. Note: we actually have a user toggle which requires a valid context. see: PixelDust-Eleven/android_frameworks_base@689d2ad#diff-aaf12e50a6456ca04b0b68baa4f299a75a33f1389d2c8c2f014b9da4a1c6893a Signed-off-by: Joey Huab <[email protected]> Signed-off-by: spezi77 <[email protected]>
For all those times you have some random app or background service that posts a Toast and you have no idea who's posting it. This adds an icon badge to the top left corner of the Toast to show the app's icon the Toast belongs to Change-Id: I82bf23664eea134f3b1f89ad5a99f6be73906ba8 Signed-off-by: spezi77 <[email protected]>
Change-Id: Iaae70f050f0121ba1a745237bd1feaf95331d8b9 Signed-off-by: spezi77 <[email protected]>
I often have trouble tapping the auto-brightness toggle with the tiny 24x24 dp touch target bound by the size of the icon. Material Design guidelines require touch targets to be at least 48x48 dp [1], so increase the size of the button to comply. This makes it much easier to tap, especially on larger devices where the top of the screen may be harder to reach. While we're at it, adjust the end margin to be effectively 24 dp. This isn't consistent with the 16 dp of margin at the start, but it's closer than before, and 24 dp is more consistent wrt. the start of the button. More space between the brightness slider and auto-brightness toggle is also helpful to prevent the ripple from colliding with the end of the slider. [1] https://material.io/design/usability/accessibility.html Change-Id: I66759b23cbac560b549a94e26ac1c8c7e5dc0ac5
Looks ugly Change-Id: I15e04b19c2d9705d5003f4eb86f13ba1636271ab
This reverts commit e244b48.
This reverts commit 2b6e501.
Some things are weird, some users are able to make it stay Also improve some code all around the class: * Update icon dim initially * Only update dim for brightness when brightness actually changed * Shorten dim animation duration * Use background thread for a setColorFilter we missed * Get rid of a useless function for setting alpha on doze, it won't work anyways
* On OnePlus 7 aka guacamoleb when turning screen on by power button in some cases short flash of brightness are observed. Method onStartedWakingUp are called little earlier than onScreenTurnedOn so lets call show from onStartedWakingUp so dim layer will have more time to hide hbm before screen will be turned on. * Do not show when already shown.
-get rid of the need for needFODCustomView bool, using supportsInDisplayFingerprint -get rid of some redundant code that is not needed
The previous commit solves the issue that users can not swipe an app away from recent apps if it was exited with the back button. (see f59b813 Fix: Recent Apps not closing) However, it still has a similar problem in the case of users press the clear all button. Because the method removeAllVisibleTasks() will remove the task record from recent tasks in an earlier stage, so removeTaskByIdLocked() can not get the task record from either task stacks or recent tasks and notifyTaskStackChanged() will not be invoked. Solution: Call notifyTaskStackChanged as well for the non-existent task Test: 1. Clear all apps from recent apps first and make sure the list is emptied 2. Open an app and exit with back button 3. Go to recent apps and press the clear all button 4. Open recent apps again and the app should be removed from the list Bug: https://issuetracker.google.com/issues/137386250 Change-Id: I7ffd36fe7760b9f087e26c768219d7e7a5f12807 Signed-off-by: Akash <[email protected]>
packageName argument was added after R33 merge, but intent extra doesn't filled, let's pass SystemUI package name if intent extra is Null Signed-off-by: DennySPb <[email protected]> Change-Id: I7de196e2632088abb2013abd2909e90b605b2d07
eldainosor
pushed a commit
that referenced
this pull request
Jun 9, 2021
Prevent SystemUI crash due to "WakeLock under-locked Doze" (issue #12) by only releasing a wakelock that was not already released Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: Joey Huab <[email protected]>
eldainosor
pushed a commit
that referenced
this pull request
Jun 9, 2021
Prevent SystemUI crash due to "WakeLock under-locked Doze" (issue #12) by only releasing a wakelock that was not already released Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: Joey Huab <[email protected]>
eldainosor
pushed a commit
that referenced
this pull request
Jul 11, 2021
Prevent SystemUI crash due to "WakeLock under-locked Doze" (issue #12) by only releasing a wakelock that was not already released Signed-off-by: Pranav Vashi <[email protected]> Signed-off-by: Joey Huab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.