Fix: Disable RDP reconnect menu item while already connecting... #2988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Related issue(s)
Copilot generated summary
Provide a Copilot generated summary of the changes in this pull request.
Copilot summary
This pull request includes several changes to the
DragablzTabHostWindow.xaml.cs
,RemoteDesktopControl.xaml.cs
, andRemoteDesktopHostViewModel.cs
files to improve the handling of remote desktop connections. The most important changes include updating the logic for connection status checks and refactoring theusing
statements.Improvements to connection status checks:
Source/NETworkManager/Controls/DragablzTabHostWindow.xaml.cs
: Updated theRemoteDesktop_IsDisconnected_CanExecute
method to also check if the control is currently connecting.Source/NETworkManager/ViewModels/RemoteDesktopHostViewModel.cs
: Modified theIsDisconnected_CanExecute
method to include a check for the connecting state.Source/NETworkManager/Controls/RemoteDesktopControl.xaml.cs
: Added a check in theReconnect
method to prevent reconnection attempts while already connecting.Refactoring:
Source/NETworkManager/Controls/DragablzTabHostWindow.xaml.cs
: Refactored theusing
statements for better organization and efficiency. [1] [2]To-Do
Contributing
By submitting this pull request, I confirm the following: