update all tests

Bosun18 · Feb 2, 2024 · 6e9500a · 6e9500a
1 parent c1e62b4
commit 6e9500a
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 25 deletions.
diff --git a/tests/Feature/LabelTest.php b/tests/Feature/LabelTest.php
@@ -12,16 +12,12 @@ class LabelTest extends TestCase
 {
     private User $user;
     private Label $label;
-    private string $name;
-    private string $nameUpdate;
 
     public function setUp(): void
     {
         parent::setUp();
         $this->user = User::factory()->create();
         $this->label = Label::factory()->create();
-        $this->name = Label::factory()->make()->name;
-        $this->nameUpdate = Label::factory()->make()->name;
     }
 
     public function testIndex(): void
@@ -40,6 +36,7 @@ public function testCreate(): void
 
     public function testStore(): void
     {
+        $this->name = Label::factory()->make()->name;
         $response = $this
             ->actingAs($this->user)
             ->post(route('labels.store'), [
@@ -62,6 +59,7 @@ public function testEdit(): void
 
     public function testUpdate(): void
     {
+        $this->nameUpdate = Label::factory()->make()->name;
         $response = $this
             ->actingAs($this->user)
             ->patch(route('labels.update', ['label' => $this->label]), [

diff --git a/tests/Feature/TaskStatusTest.php b/tests/Feature/TaskStatusTest.php
@@ -11,16 +11,12 @@ class TaskStatusTest extends TestCase
 {
     private User $user;
     private TaskStatus $taskStatus;
-    private string $name;
-    private string $nameUpdate;
 
     public function setUp(): void
     {
         parent::setUp();
         $this->user = User::factory()->create();
         $this->taskStatus = TaskStatus::factory()->create();
-        $this->name = TaskStatus::factory()->make()->name;
-        $this->nameUpdate = TaskStatus::factory()->make()->name;
     }
 
 
@@ -40,6 +36,7 @@ public function testCreate(): void
 
     public function testStore(): void
     {
+        $this->name = TaskStatus::factory()->make()->name;
         $response = $this
             ->actingAs($this->user)
             ->post(route('task_statuses.store'), [
@@ -62,6 +59,7 @@ public function testEdit(): void
 
     public function testUpdate(): void
     {
+        $this->nameUpdate = TaskStatus::factory()->make()->name;
         $response = $this
             ->actingAs($this->user)
             ->patch(route('task_statuses.update', ['task_status' => $this->taskStatus]), [

diff --git a/tests/Feature/TaskTest.php b/tests/Feature/TaskTest.php
@@ -4,15 +4,12 @@
 
 use Tests\TestCase;
 use App\Models\User;
-use App\Models\TaskStatus;
 use App\Models\Task;
 
 class TaskTest extends TestCase
 {
     private User $user;
     private Task $task;
-    private array $newTaskData;
-    private array $taskDataForUpdate;
 
     public function setUp(): void
     {
@@ -22,20 +19,6 @@ public function setUp(): void
         $this->task = Task::factory()->create([
             'created_by_id' => $this->user->id,
         ]);
-
-        $this->newTaskData = Task::factory()->make()->only([
-            'name',
-            'description',
-            'status_id',
-            'assigned_to_id',
-        ]);
-
-        $this->taskDataForUpdate = Task::factory()->make()->only([
-            'name',
-            'description',
-            'status_id',
-            'assigned_to_id',
-        ]);
     }
 
     public function testIndex(): void
@@ -57,6 +40,12 @@ public function testCreate(): void
      */
     public function testStore(): void
     {
+        $this->newTaskData = Task::factory()->make()->only([
+            'name',
+            'description',
+            'status_id',
+            'assigned_to_id',
+        ]);
         $response = $this
             ->actingAs($this->user)
             ->post(route('tasks.store'), $this->newTaskData);
@@ -87,6 +76,12 @@ public function testEdit(): void
      */
     public function testUpdate(): void
     {
+        $this->taskDataForUpdate = Task::factory()->make()->only([
+            'name',
+            'description',
+            'status_id',
+            'assigned_to_id',
+        ]);
         $response = $this
             ->actingAs($this->user)
             ->patch(route('tasks.update', ['task' => $this->task]), $this->taskDataForUpdate);