feat(sumologic-image-widget) : Hubot can display widget from a sumologic dashboard #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sumo API still in beta on that part, doesn't work well on dashboard description and especially on widget description the part we need of course ;)
- (test only) info available to get dashboard info - (test only) data available to get dashboard data - (wip) show, for now you have to enter a combo dashboardid-widgetid for display a picture of a dash. - exclude dump.rdb created by local hubot
- Dev task just run hubot locally
|
🚀 |
| @@ -49,6 +63,7 @@ module.exports = (robot) -> | |||
| Dashboard URL manager | |||
| `!dashboard set <url>` : Switch to given URL | |||
| `!dashboard sumo <dashboardId>` : Switch to the dashboardId URL | |||
| `!dashboard show <dashboardId>-<widgetId>` : Get picture of a widget | |||
There was a problem hiding this comment.
In my mind, dashboard means the TV Dashboard :)
Maybe use a sumologic cmd ? :)
There was a problem hiding this comment.
This one is just for testing, will disappear when finished ^^
There was a problem hiding this comment.
for sure, feel free it's a dashboard TV manager, I don't have TV
There was a problem hiding this comment.
You should buy one 😜
Really under construction lol, I think I will move my dev in an other place at the end
There was a problem hiding this comment.
For sure I should buy one.
Waiting our office keys 🍭
- Find the logic between sumologic data and how use them in a stacked bar chart.
- Check readme im tired ;)
|
|
||
| console.log "Ready to slack it !" | ||
|
|
||
| form.submit("https://slack.com/api/files.upload", (err, res) -> |
There was a problem hiding this comment.
So nice ! But it's not finished yet !
…b.com/Boulangerie/hubot-mill into payou-playground-graph-img-generation
- Format chart of type stackedBar (Waouuu) - Clean and tidy mocks - Next: Finish stackedBar format data for highchart
- stackedBar works but it is ugly
- Bonus : Roadmap updated
- Implement Promise and allow chainability - Untie widgetFinder/GraphBuilder/sendToSlack - sumo command is now composed of each logic step. - Formatters disappear replaced by Charts - Charts use a lib like highchart or not and each one is responsible to how they will render in a dom window. - Hubot can be teleported to be shared accross classes - Some clean - Highcharts helper should be done - SvgHelper will be implemented soon - (WIP) Non tested yet !
- Update readme todo ^^
- Use highcharts on backstage
- They are just template to fill for now - Implemented in graphBuilder
- Previously we expect the constructor of a graph class to return the jsDom document object. This wasn't a good idea now each graph class have to implement a method getSvg which is responsible to return the expected svg string. - This allow us to do what we want in graph class instead of adding a hidden dep to jsdom...
- This graph doesn't rely on highcharts, they are too simple ! We directly use svg template for them. They are pretty simple for now and aren't able to color them like sumo. We don't have this rules so we can't do that for now. - Next : Bind this graphs to sumo data !
- Update roadmap too - Transformation from sumo is too simple and doesn't handle all cases.
- now : graphBuilder try to use temp file - next : Test it / export code to a dedicated class
- Working code but completely ugly - Refactor it in clean class in next commit plz !
- SendToslack left for integration.
- Now need a beautiful one ;)
- File uploaded with a special name can be considered as a source of knowledge by hubot - He try to get this file, parse it as json and extend his memory. - Brain is used for persistence. - WidgetFinder is now based on it - Readme updated
- not removed for let a footprint of how this works
-> lobotomize sumo
- SendToSlack should work everywhere - We log a bit more the main process - Todo removed and done 🧌
- Error to finish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 🚧 Work in progress 🚧 🚧