Skip to content

Commit

Permalink
fix: get python release working again (#1218)
Browse files Browse the repository at this point in the history
<!-- ELLIPSIS_HIDDEN -->



> [!IMPORTANT]
> Pin `maturin` version to `1.7.6` in GitHub Actions to fix Python
release issues.
> 
>   - **GitHub Actions Workflow**:
> - Pin `maturin` version to `1.7.6` in
`.github/workflows/build-python-release.reusable.yaml` to fix release
issues with `gh-action-pypi-publish`.
> - Added comments explaining the issue with `maturin` versions `1.7.7+`
and links to related issues and changelogs.
> 
> <sup>This description was created by </sup>[<img alt="Ellipsis"
src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=BoundaryML%2Fbaml&utm_source=github&utm_medium=referral)<sup>
for 1105006. It will automatically
update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->
  • Loading branch information
sxlijin authored Dec 5, 2024
1 parent a37d486 commit bde634c
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .github/workflows/build-python-release.reusable.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,13 @@ jobs:
env: ${{ matrix._.env || fromJSON('{}') }}
with:
target: ${{ matrix._.target }}
# TODO: unpin the maturin version
# 1.7.7+ builds wheels that gh-action-pypi-publish can't upload
# see:
# - release failure: https://github.com/BoundaryML/baml/actions/runs/12154379580/job/33894619438
# - maturin changelog: https://github.com/PyO3/maturin/blob/ba4d482809a73669242bd7fe7dd5f9106f42702f/Changelog.md?plain=1#L13
# - gh-action-pypi-publish issue: https://github.com/pypa/gh-action-pypi-publish/issues/310
maturin-version: "1.7.6"
command: build
# building in engine/ ensures that we pick up .cargo/config.toml
working-directory: engine
Expand Down

0 comments on commit bde634c

Please sign in to comment.