Skip to content

Commit

Permalink
fix: CreateDeployment returns deployment_tag, not deployment_id (#1210)
Browse files Browse the repository at this point in the history
<!-- ELLIPSIS_HIDDEN -->



> [!IMPORTANT]
> Rename `deployment_id` to `deployment_tag` in
`CreateDeploymentResponse` to match API response in `api_client.rs`.
> 
>   - **Behavior**:
> - Rename `deployment_id` to `deployment_tag` in
`CreateDeploymentResponse` in `api_client.rs` to match API response.
>   - **Functions**:
> - `create_deployment` in `ApiClient` now correctly handles
`deployment_tag` instead of `deployment_id`.
> 
> <sup>This description was created by </sup>[<img alt="Ellipsis"
src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=BoundaryML%2Fbaml&utm_source=github&utm_medium=referral)<sup>
for 05fd646. It will automatically
update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->
  • Loading branch information
sxlijin authored Dec 4, 2024
1 parent 441fbba commit f8593ee
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion engine/cli/src/api_client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ pub struct CreateDeploymentRequest {
#[derive(Debug, Deserialize)]
pub struct CreateDeploymentResponse {
#[allow(dead_code)]
deployment_id: String,
deployment_tag: String,
}

impl ApiClient {
Expand Down

0 comments on commit f8593ee

Please sign in to comment.