what's different?

[sxlijin]

Important

Add reusable GitHub Actions workflow for TypeScript builds and update related configurations and scripts.

• Workflows:
  • Adds build-typescript-release.reusable.yaml for building TypeScript releases across multiple platforms.
  • Updates release.yml to use the new reusable workflow for TypeScript builds.
• Configuration:
  • Updates Node.js version to 20.14 in .mise.toml.
  • Specifies musl linkers in Cargo.toml for x86_64 and aarch64 targets.
• Scripts:
  • Adds setup-cross-compile-env.sh for setting up a cross-compilation environment in Docker.

^{This description was created by for 39d8b4c. It will automatically update as commits are pushed.}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
baml	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Oct 14, 2024 11:11pm

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 39d8b4c in 29 seconds

More details

• Looked at 370 lines of code in 5 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. tools/setup-cross-compile-env.sh:60

• Draft comment:
  Consider making the bash shell startup optional or controlled by a flag, as it may not be necessary for all use cases.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The setup-cross-compile-env.sh script ends with starting a bash shell, which might not be necessary for all use cases. This could be optional or controlled by a flag.

2. engine/language_client_typescript/Cargo.toml:14

• Draft comment:
  Ensure that the specified musl linkers (x86_64-linux-musl-gcc and aarch64-linux-musl-gcc) are available in the build environment to avoid compilation errors.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The Cargo.toml file specifies a linker for musl targets, which is necessary for cross-compilation. However, it's important to ensure that these linkers are available in the build environment.

3. .github/workflows/build-typescript-release.reusable.yaml:111

• Draft comment:
  Ensure that all necessary dependencies are installed before running pnpm build:napi-release to avoid build failures.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The build-typescript-release.reusable.yaml file uses pnpm build:napi-release for building, which is fine, but it's important to ensure that all necessary dependencies are installed before this step.

Workflow ID: wflow_mJlx0olfx2qRKd6C

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

Consider updating the package list before installing curl on Ubuntu/Debian systems to avoid potential issues with outdated package lists.

Suggested change

	apt install -y curl
	apt-get update && apt-get install -y curl