Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up cargo.toml warnings #1047

Merged
merged 2 commits into from
Oct 16, 2024
Merged

chore: clean up cargo.toml warnings #1047

merged 2 commits into from
Oct 16, 2024

Conversation

sxlijin
Copy link
Collaborator

@sxlijin sxlijin commented Oct 16, 2024

Important

Cleaned up Cargo.toml warnings by removing target-specific configurations and updated GitHub Actions workflow naming and branch specifications.

  • Cargo.toml:
    • Removed [target.x86_64-unknown-linux-musl] and [target.aarch64-unknown-linux-musl] sections.
  • GitHub Actions:
    • In build-ruby-release.reusable.yaml, added name: ${{ matrix._.platform }} for job naming.
    • In build-typescript-release.reusable.yaml, changed branch from sam/alpine-builds to sam/alpine-warnings and adjusted job name to name: ${{ matrix._.target }}.

This description was created by Ellipsis for c9103a7. It will automatically update as commits are pushed.

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
baml ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 6:29pm

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c9103a7 in 10 seconds

More details
  • Looked at 53 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. engine/language_client_typescript/Cargo.toml:7
  • Draft comment:
    Removing target-specific linker configurations might affect cross-compilation. Ensure these targets are not needed for your builds.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR removes specific target configurations from Cargo.toml, which might be intentional to clean up warnings. However, this could affect cross-compilation if those targets are needed.

Workflow ID: wflow_7dvPdALyIxr14GS5


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@sxlijin sxlijin added this pull request to the merge queue Oct 16, 2024
Merged via the queue into canary with commit 3ee81d5 Oct 16, 2024
17 checks passed
@sxlijin sxlijin deleted the sam/alpine-warnings branch October 16, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant