[bugfix] literals in template strings #1132
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to a2180b3 in 38 seconds
More details
- Looked at
155lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_VKsK1T5XIpb7RRJN
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| minijinja::value::ValueKind::Bool => Type::Bool, | ||
| minijinja::value::ValueKind::String => Type::String, | ||
| minijinja::value::ValueKind::Bool => { | ||
| match bool::from_str(&v.to_string()) { |
There was a problem hiding this comment.
Using bool::from_str on the stringified value of minijinja::value::Value is not ideal. Consider directly converting the Value to a boolean without string conversion.
| match bool::from_str(&v.to_string()) { | |
| match v.as_bool().unwrap_or(false) { |
| @@ -410,7 +417,12 @@ | |||
| } | |||
| minijinja::value::ValueKind::Map => Type::Unknown, | |||
| // We don't handle these types | |||
| minijinja::value::ValueKind::Number => Type::Number, | |||
| minijinja::value::ValueKind::Number => { | |||
| match i64::from_str(&v.to_string()) { | |||
There was a problem hiding this comment.
Using i64::from_str on the stringified value of minijinja::value::Value is not ideal. Consider directly converting the Value to an integer without string conversion.
| match i64::from_str(&v.to_string()) { | |
| match v.as_i64() { |
Important
Fixes handling of literals in template strings by updating type inference and test cases to correctly identify and evaluate literal values.
infer_const_typeinexpr.rsto returnType::LiteralforBool,String, andNumberkinds.test_expr.rsandtest_stmt.rsto reflect literal types in function argument errors.test_ifexpr,test_call_function, andtest_output_formatintest_expr.rsto check forType::Literal.if_elseintest_stmt.rsto handle literal types in conditional expressions.This description was created by
for a2180b3. It will automatically update as commits are pushed.