Fix template string highlights #1182
Merged
+439
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 5ce06a5 in 36 seconds
More details
- Looked at
662lines of code in10files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_nN65ylgXfP0CxjLw
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -83,26 +83,27 @@ | |||
| "1": { "name": "storage.type.declaration.function" }, | |||
| "2": { "name": "entity.name.function" } | |||
| }, | |||
| "end": "(\")(#{1,3})", | |||
|
|
|||
| "end": "^(\"#{1,3})", | |||
There was a problem hiding this comment.
The regex pattern for the end of a template string declaration should match the same number of hash symbols as the beginning. Consider changing the end pattern to "\1 to ensure consistency.
Suggested change
| "end": "^(\"#{1,3})", | |
| "end": "^("\1)", |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fixes template string highlighting in BAML files and adds a
Completionfunction for handling template string completions.baml.tmLanguage.jsonby adjusting the regex patterns fortemplate_string_declarationandtemplate_string_body.block_string_pairandfunction_declaration2patterns to handle multi-line strings correctly.Completionfunction to handle template string completions inasync_client.py,sync_client.py, andclient.rb.template_string.bamltest file to verify template string handling.inlinedbaml.pyandinlined.rbto include the new test file.This description was created by
for 5ce06a5. It will automatically update as commits are pushed.