Fix nextjs and TS server hot-reload #1183
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 21068e8 in 20 seconds
More details
- Looked at
71lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_cDA0b2OJketCnO74
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| try { | ||
| // some filewatchers don't trigger unless the file is touched. Creating the new dir alone doesn't work. | ||
| // if we remove this, TS will still have the old types, and nextjs will not hot-reload. | ||
| g.files.map((f) => { |
There was a problem hiding this comment.
Using map here is misleading since the result is not used. Consider using forEach instead for clarity and performance.
| g.files.map((f) => { | |
| g.files.forEach((f) => { |
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 7c891bc in 18 seconds
More details
- Looked at
21lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_Bxi8RHVYLet6b82v
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| const fpath = path.join(g.output_dir, f.path_in_output_dir) | ||
| const currentTime = new Date() | ||
| const newTime = new Date(currentTime.getTime() + 100) | ||
| utimes(fpath, newTime, newTime, (err) => { |
There was a problem hiding this comment.
Consider using fs.promises.utimes for better consistency and error handling.
| utimes(fpath, newTime, newTime, (err) => { | |
| await fs.promises.utimes(fpath, newTime, newTime) |
Important
Fixes Next.js and TypeScript server hot-reload by changing
restartTSServerOnSavedefault and modifying file timestamps.restartTSServerOnSavedefault tofalseinbamlConfig.tsandpackage.json.baml_project_manager.tsto trigger file watchers for hot-reload.utimesimport fromfsinbaml_project_manager.ts.This description was created by
for 7c891bc. It will automatically update as commits are pushed.