Greg/alias example

[antoniosarosi]

Important

Adds RunFoo2 function across clients, new types, refines recursive type handling, and updates unreachable code with context.

• New Functionality:
  • Adds RunFoo2 function to Python (async_client.py, sync_client.py), Ruby (client.rb), and TypeScript (async_client.ts, sync_client.ts) clients.
  • Introduces Foo2 and Foo3 types in types.py, types.rb, and types.ts.
• Code Improvements:
  • Replaces unreachable!() with unreachable!("context") in expr.rs, coerce_array.rs, coerce_optional.rs, and coerce_union.rs.
  • Refactors recursive type handling in types.rs.
• Testing:
  • Adds test_constrained_type_alias in test_runtime.rs.
  • Adds test_type_alias_with_assert in test_file_manager.rs.
  • Adds test_alias_bug in test_functions.py.
• Miscellaneous:
  • Adds antonio.baml test file for integration tests.

^{This description was created by for 10f4999. It will automatically update as commits are pushed.}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
baml	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 12, 2024 8:20pm

[ellipsis-dev]

👍 Looks good to me! Incremental review on 10f4999 in 52 seconds

More details

• Looked at 666 lines of code in 18 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. integ-tests/typescript/baml_client/types.ts:321

• Draft comment:
  The PR description mentions the addition of RunFoo2 function and related types, but the code changes show the removal of Foo2 and Foo3 types and RunFoo2 function. This discrepancy needs clarification.
• Reason this comment was not posted:
  Comment did not seem useful.

Workflow ID: wflow_FESoynO9lMvEREm4

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 9bd01b8 in 10 minutes and 41 seconds

More details

• Looked at 893 lines of code in 25 files
• Skipped 0 files when reviewing.
• Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_VuTIFCQ9qYCduPk4

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

The 'sub' property in the Foo2 interface is redundantly nullable. It should be simplified to sub?: Foo2 | null. This applies to Foo3 as well.