chore: force push npm package #1245
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to b3aca84 in 36 seconds
More details
- Looked at
338lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_7J2fSnCJBmK8WY0i
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
.github/workflows/release.yml
Outdated
| @@ -117,6 +119,8 @@ jobs: | |||
| with: | |||
| pattern: bindings-* | |||
| path: engine/language_client_typescript/artifacts | |||
| run-id: 12318760112 | |||
There was a problem hiding this comment.
The 'run-id' and 'github-token' fields in the 'actions/download-artifact' step are not standard and might cause issues. They should be removed unless they are part of a custom action that requires them.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 0fba3a3 in 9 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. engine/language_client_typescript/package.json:7
- Draft comment:
The change from 'https' to 'git+' in the repository URL is unnecessary for npm package.json files. Consider reverting to 'https://github.com/BoundaryML/baml.git'. - Reason this comment was not posted:
Confidence changes required:50%
The change from 'https' to 'git+' in the repository URL is unnecessary for npm package.json files. It doesn't affect the functionality but could be misleading.
Workflow ID: wflow_R5a1u2NWBJXsjKyH
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 53656cb in 32 seconds
More details
- Looked at
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_HMVjM2QoFvjwrp50
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
.github/workflows/release.yml
Outdated
| @@ -128,99 +132,100 @@ jobs: | |||
|
|
|||
| - name: Publish | |||
| run: | | |||
| npm adduser | |||
There was a problem hiding this comment.
The npm adduser command is unnecessary here as authentication is managed via the NODE_AUTH_TOKEN. Consider removing it to streamline the workflow.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 9f25456 in 14 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/release.yml:113
- Draft comment:
Ensure that theregistry-urlsetting does not conflict with other registry settings in the workflow. - Reason this comment was not posted:
Confidence changes required:50%
The addition ofregistry-urlis correct and aligns with the intent to focus on npm publishing. However, it's important to ensure that this change does not conflict with any other registry settings in the workflow.
Workflow ID: wflow_VJejVgbiPgZyRBDf
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 32266aa in 16 seconds
More details
- Looked at
25lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/release.yml:111
- Draft comment:
The comment is incorrect. TheNODE_AUTH_TOKENis used as an environment variable, as specified in theenvsection. Update the comment to reflect this. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_wZuXBqYFLf5847r6
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 961d18b in 28 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/release.yml:114
- Draft comment:
Consider uncommenting theregistry-urlline to ensure the npm registry is explicitly set tohttps://registry.npmjs.org. This can prevent issues if the default registry is not npmjs.org. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is about a change made in the diff, specifically the commenting out of theregistry-urlline. The suggestion to uncomment it is based on the potential issue of the default registry not being npmjs.org. However, the comment is speculative as it assumes a problem that may not exist. The change might have been intentional, and the comment does not provide strong evidence that the change is incorrect.
The comment could be seen as a valid suggestion to prevent potential issues, but it lacks strong evidence that the change is incorrect or problematic. It is speculative and assumes a problem without certainty.
While the comment is speculative, it does address a potential issue that could arise from the change. However, without strong evidence that the change is incorrect, the comment does not meet the criteria for being kept.
The comment should be deleted as it is speculative and lacks strong evidence that the change is incorrect or problematic.
Workflow ID: wflow_3hQpb95xCq3FRWZ8
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 033abba in 9 seconds
More details
- Looked at
331lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_LceDPPoUQDSQ2rbR
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Important
Modifies GitHub Actions to focus on npm publishing and updates repository URL in
package.json.sam/npm-token-fixto trigger workflow inrelease.yml.release.yml.publish-to-npmjob to run independently withoutall-buildsdependency inrelease.yml.run-idandgithub-tokenparameters toactions/download-artifactstep inpublish-to-npm.package.json.This description was created by
for 033abba. It will automatically update as commits are pushed.