Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for azure and failure scenarios #1250

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Add tests for azure and failure scenarios #1250

merged 2 commits into from
Dec 17, 2024

Conversation

aaronvg
Copy link
Contributor

@aaronvg aaronvg commented Dec 17, 2024

Important

Add tests for Azure functionality and failure scenarios in integ-tests.test.ts, including streaming and non-streaming cases.

  • Tests:
    • Add should support azure and should support azure streaming tests in integ-tests.test.ts.
    • Add should fail if azure is not configured test in integ-tests.test.ts.
    • Comment out should fail if azure is not configured streaming test in integ-tests.test.ts.
  • Behavior:
    • should support azure tests Azure functionality.
    • should support azure streaming tests Azure streaming functionality.
    • should fail if azure is not configured tests Azure failure scenario.
    • should fail if azure is not configured streaming is commented out, indicating incomplete or failing test.
  • Misc:
    • Update test-report.html to reflect new test results.

This description was created by Ellipsis for 504d853. It will automatically update as commits are pushed.

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
baml ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 1:16am

@aaronvg aaronvg enabled auto-merge December 17, 2024 01:11
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ac9df80 in 1 minute and 17 seconds

More details
  • Looked at 1141 lines of code in 11 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. integ-tests/typescript/tests/integ-tests.test.ts:373
  • Draft comment:
    The test case for 'should fail if azure is not configured streaming' is commented out. If this is intentional for debugging, consider adding a comment explaining why. Otherwise, it should be removed or uncommented if needed.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The test case for 'should fail if azure is not configured streaming' is commented out, which might be intentional for debugging or other reasons. However, it should be addressed or removed if not needed.

Workflow ID: wflow_4LoZTUG9zgUPfOyt


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 504d853 in 36 seconds

More details
  • Looked at 55 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. integ-tests/baml_src/test-files/providers/providers.baml:33
  • Draft comment:
    Ensure that the resource name "west-us-azure-baml-incorrect-suffix" is only used for testing failure scenarios and not in production environments.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change in the resource name from "west-us-azure-bamll" to "west-us-azure-baml-incorrect-suffix" is intentional for testing failure scenarios. However, it should be noted that this change is only for testing purposes and should not be used in production.

Workflow ID: wflow_aQBGUAminjCYfFuH


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@aaronvg aaronvg added this pull request to the merge queue Dec 17, 2024
Merged via the queue into canary with commit 20ec134 Dec 17, 2024
10 of 11 checks passed
@aaronvg aaronvg deleted the azure-integ-test branch December 17, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant