-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ollama.mdx #1323
Update ollama.mdx #1323
Conversation
throws an error about base_url if the next line for model has no quotes around the model
@hfnhf is attempting to deploy a commit to the Gloo Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 07e0fd3 in 7 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. fern/03-reference/baml/clients/providers/ollama.mdx:22
- Draft comment:
The addition of quotes around the model name is correct and necessary to prevent syntax errors related to thebase_url
. This change ensures the model name is interpreted as a string. - Reason this comment was not posted:
Confidence changes required:0%
The PR correctly adds quotes around the model name, which is necessary for proper syntax in this context. The change aligns with the requirement to avoid errors related to base_url.
Workflow ID: wflow_JcT5e70memrIXu54
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
hmm this one works for me for example:
|
your client in your function should say "CustomOllama" |
update one of two: add quotes around model name on
throws an error about base_url if the next line for model has no quotes around the model
update two of two:
change example model to a nice fully open model
https://ollama.com/library/[tulu3](https://ollama.com/library/tulu3)
end result:
no such error message about base_url (BAML 0.72.0 open-vsx extension is installed, screenshot to show)
Important
Fixes base_url error by quoting model name and updates example model to
tulu3
inollama.mdx
.tulu3
inollama.mdx
to prevent a base_url error.llama3
totulu3
inollama.mdx
for a fully open model.This description was created by for 07e0fd3. It will automatically update as commits are pushed.