Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix field type parsing #1349

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Fix field type parsing #1349

merged 1 commit into from
Jan 20, 2025

Conversation

hellovai
Copy link
Contributor

@hellovai hellovai commented Jan 20, 2025

Important

Replace unreachable_rule! with parsing_catch_all in parse_field_type to improve error handling.

  • Error Handling:
    • Replace unreachable_rule! with parsing_catch_all in parse_field_type in parse_types.rs to handle unexpected cases more gracefully.

This description was created by Ellipsis for fcf3a6e. It will automatically update as commits are pushed.

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
baml ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 6:39pm

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to fcf3a6e in 15 seconds

More details
  • Looked at 22 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. engine/baml-lib/schema-ast/src/parser/parse_types.rs:36
  • Draft comment:
    Consider replacing unreachable! with a more informative error handling approach to provide better diagnostics.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_V5ozIkvrHAutg31w


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@aaronvg aaronvg added this pull request to the merge queue Jan 20, 2025
Merged via the queue into canary with commit d08445f Jan 20, 2025
11 checks passed
@aaronvg aaronvg deleted the compiler-fix branch January 20, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants