Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static analyzer #1558

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from
Open

Fix static analyzer #1558

wants to merge 1 commit into from

Conversation

hellovai
Copy link
Contributor

@hellovai hellovai commented Mar 3, 2025

Important

Adds call_function_sync() method to BamlRuntime class for synchronous function calls in baml_py.pyi.

  • Behavior:
    • Adds call_function_sync() method to BamlRuntime class in baml_py.pyi for synchronous function calls.
  • Misc:
    • No other changes or refactoring noted in the diff.

This description was created by Ellipsis for 9937a29. It will automatically update as commits are pushed.

Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
baml ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 11:59pm

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9937a29 in 1 minute and 22 seconds

More details
  • Looked at 20 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. engine/language_client_python/python_src/baml_py/baml_py.pyi:92
  • Draft comment:
    Good addition: new call_function_sync signature is consistent with async version.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
2. engine/language_client_python/python_src/baml_py/baml_py.pyi:92
  • Draft comment:
    Added synchronous call_function_sync signature. It mirrors the async variant in parameters. Ensure the actual implementation remains consistent.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 20% <= threshold 50%
    The comment is informative, explaining that a new synchronous function signature has been added and that it mirrors an async variant. However, it also includes a directive to "Ensure the actual implementation remains consistent," which is a request for verification. This part of the comment is not specific enough to be useful, as it doesn't point out a specific issue or suggest a specific action. Therefore, the comment is not approved.

Workflow ID: wflow_1aU8aTvk0d4j4sdg


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant