Fix language server crash relying on node crypto #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 35a931e in 49 seconds
More details
- Looked at
27lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. typescript/vscode-ext/packages/language-server/src/server.ts:37
- Draft comment:
Removing the global assignment of the Node.js 'crypto' module is a significant change. Ensure that all cryptographic operations in the language server and its dependencies are compatible with this change and that there is an alternative implementation that does not rely on Node.js-specific features. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_8NpKBKSJhnZRS6Oq
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
aaronvg
force-pushed
the
vscode-crash-fix
branch
from
35a931e to
900d14e
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 900d14e in 56 seconds
More details
- Looked at
130lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. typescript/vscode-ext/packages/package.json:5
- Draft comment:
The PR description states the version was incremented from0.36.0to0.36.1, but the diff shows an increment to0.36.2. Please confirm the correct version update. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_AkqmFNVQftACBX7B
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -548,6 +548,7 @@ | |||
| break | |||
|
|
|||
| case 'port_number': | |||
| console.log('Setting port number', content.port) | |||
Check warning
Code scanning / CodeQL
Log injection Medium
anish-palakurthi
pushed a commit
that referenced
this pull request
Jun 11, 2024
<!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 900d14e | |--------|--------| ### Summary: This PR addresses crashes by removing the assignment of Node's `crypto` module to `globalThis.crypto` in the language server and updates the package version. **Key points**: - Removed global assignment of `crypto` to `node:crypto`'s `webcrypto` in `server.ts`. - Removed assignment of Node's `crypto` module to `globalThis.crypto` in `server.ts`. - Updated package version in `package.json` from `0.36.0` to `0.36.1`. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR addresses crashes by removing the assignment of Node's
cryptomodule toglobalThis.cryptoin the language server and updates the package version.Key points:
cryptotonode:crypto'swebcryptoinserver.ts.cryptomodule toglobalThis.cryptoinserver.ts.package.jsonfrom0.36.0to0.36.1.Generated with ❤️ by ellipsis.dev