fix: correctly propagate LICENSE to baml-py #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users who `pip install baml-py` are currently confronted with an error about LICENSE not being reflected in the wheel's RECORD file. Looks like maturin doesn't play nice with `license.workspace = true` in a monorepo. ``` Warning: Validation of the RECORD file of baml_py-0.40.0-cp38-abi3-macosx_11_0_arm64.whl failed. Please report to the maintainers of that package so they can fix their build process. Details: In /Users/sam/baml/engine/target/wheels/baml_py-0.40.0-cp38-abi3-macosx_11_0_arm64.whl, baml_py-0.40.0.dist-info/license_files/LICENSE is not mentioned in RECORD ``` Verified using this command: ``` poetry remove baml-py; poetry run maturin build --manifest-path ~/baml/engine/language_client_python/Cargo.toml && poetry add ~/baml/engine/target/wheels/baml_py-0.40.0-cp38-abi3-macosx_11_0_arm64.whl ``` Fix, I suspect, was some combination of using `license` instead of `license-file` in `Cargo.toml` and not referencing the Cargo workspace. Also see the maturin docs: https://www.maturin.rs/metadata#add-spdx-license-expressions
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
sxlijin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users who
pip install baml-pyare currently confronted with an error about LICENSE not being reflected in the wheel's RECORD file. Looks like maturin doesn't play nice withlicense.workspace = truein a monorepo.Verified using this command:
Fix, I suspect, was some combination of using
licenseinstead oflicense-fileinCargo.tomland not referencing the Cargo workspace. Also see the maturin docs:https://www.maturin.rs/metadata#add-spdx-license-expressions
Fixes #690
Also filed PyO3/maturin#2116 for the upstream issue