Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: populate the build cache #753

Merged
merged 4 commits into from
Jul 8, 2024
Merged

chore: populate the build cache #753

merged 4 commits into from
Jul 8, 2024

Conversation

sxlijin
Copy link
Collaborator

@sxlijin sxlijin commented Jul 3, 2024

No description provided.

Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
baml ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 6:28pm

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

No major changes found since last review.

No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

No major changes found since last review.

No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

  • Added new TypeScript files for BamlCtxManager, BamlStream, and type builders (engine/language_client_typescript/async_context_vars.d.ts, stream.d.ts, type_builder.d.ts)
  • Introduced provider field to OpenAIClient struct and conditional stream_options in build_request (engine/baml-runtime/src/internal/llm_client/primitive/openai/openai_client.rs)
  • Enhanced error handling in post method of CompleteAPIConfig (engine/baml-runtime/src/tracing/api_wrapper/mod.rs)
  • Updated logging format for better error detail visibility (engine/baml-runtime/src/tracing/threaded_tracer.rs)
  • Incremented version numbers across multiple configuration files (Cargo.toml, pyproject.toml, baml.gemspec, package.json)

44 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

  • Adjusted JSX element property ordering for readability (typescript/playground-common/src/shared/Selectors.tsx)
  • Updated button className for text color styling (typescript/playground-common/src/shared/SettingsDialog.tsx)

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@sxlijin sxlijin merged commit 9bc57c9 into canary Jul 8, 2024
8 checks passed
@sxlijin sxlijin deleted the sam/gh-actions branch July 8, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant