improve error handling when submitting logs to api #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Improved error handling in
engine/baml-runtime/src/tracing/api_wrapper/mod.rsby capturing response body on errors. - Removed panic statements for unsupported media types in
engine/baml-runtime/src/tracing/mod.rs. - Enhanced error messages in
engine/baml-runtime/src/tracing/threaded_tracer.rsfor failed log submissions. - Added
DummyOutputclass and related builders ininteg-tests/python/baml_client/partial_types.py,type_builder.py, andtypes.py. - Introduced new tests in
integ-tests/python/tests/test_functions.pyfor validating error handling improvements.
13 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integ tests for catching parsing errors