Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fiddle build fix #800

Merged
merged 8 commits into from
Jul 19, 2024
Merged

fiddle build fix #800

merged 8 commits into from
Jul 19, 2024

Conversation

aaronvg
Copy link
Contributor

@aaronvg aaronvg commented Jul 18, 2024

  • fix vercel build
  • Fix promptfiddle build

Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
baml ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 5:33am

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Updated typescript/fiddle-frontend/vercel-build.sh to verify clang and llvm-config versions
  • Added installation step for g++ using sudo apt install
  • Ensured necessary tools and dependencies are available for the build process

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

  • Commented out clang --version in typescript/fiddle-frontend/vercel-build.sh
  • No major changes found since last review

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

  • Commented out clang --version in typescript/fiddle-frontend/vercel-build.sh
  • No major changes found since last review

No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

  • Commented out llvm-config --version in typescript/fiddle-frontend/vercel-build.sh
  • Ensured installation of g++ in typescript/fiddle-frontend/vercel-build.sh

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

  • Switched package manager from apt to dnf for g++ installation in typescript/fiddle-frontend/vercel-build.sh
  • No major changes found since last review

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

  • Modified typescript/fiddle-frontend/vercel-build.sh to install llvm and clang instead of g++
  • Ensured Rust environment configuration in typescript/fiddle-frontend/vercel-build.sh
  • Updated wasm-bindgen package in typescript/fiddle-frontend/vercel-build.sh

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

  • Added AWS deployment page in docs/docs.yml
  • Introduced version field in docs/docs/calling-baml/generate-baml-client.mdx
  • Added VSCode settings in docs/docs/doc-snippets/vscode-settings.mdx
  • Updated docs/docs/get-started/debugging/vscode-playground.mdx with troubleshooting section
  • Simplified engine/baml-lib/baml/tests/validation_files/generators/v1.baml

27 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@aaronvg aaronvg merged commit d304203 into canary Jul 19, 2024
9 checks passed
@aaronvg aaronvg deleted the fiddle-build-fix branch July 19, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant