-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fiddle build fix #800
fiddle build fix #800
Conversation
aaronvg
commented
Jul 18, 2024
- fix vercel build
- Fix promptfiddle build
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Updated
typescript/fiddle-frontend/vercel-build.sh
to verifyclang
andllvm-config
versions - Added installation step for
g++
usingsudo apt install
- Ensured necessary tools and dependencies are available for the build process
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Commented out
clang --version
intypescript/fiddle-frontend/vercel-build.sh
- No major changes found since last review
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Commented out
clang --version
intypescript/fiddle-frontend/vercel-build.sh
- No major changes found since last review
No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Commented out
llvm-config --version
intypescript/fiddle-frontend/vercel-build.sh
- Ensured installation of
g++
intypescript/fiddle-frontend/vercel-build.sh
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Switched package manager from
apt
todnf
forg++
installation intypescript/fiddle-frontend/vercel-build.sh
- No major changes found since last review
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Modified
typescript/fiddle-frontend/vercel-build.sh
to installllvm
andclang
instead ofg++
- Ensured Rust environment configuration in
typescript/fiddle-frontend/vercel-build.sh
- Updated
wasm-bindgen
package intypescript/fiddle-frontend/vercel-build.sh
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Added AWS deployment page in
docs/docs.yml
- Introduced
version
field indocs/docs/calling-baml/generate-baml-client.mdx
- Added VSCode settings in
docs/docs/doc-snippets/vscode-settings.mdx
- Updated
docs/docs/get-started/debugging/vscode-playground.mdx
with troubleshooting section - Simplified
engine/baml-lib/baml/tests/validation_files/generators/v1.baml
27 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings