Dont drop extra fields in dynamic classes when passing them as inputs to a function #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added
test_dynamic_inputs_list2to verify handling of dynamic inputs with nested properties ininteg-tests/python/tests/test_functions.py - Imported
DynInputOutputclass frombaml_client.typesto support the new test
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
hellovai
reviewed
Jul 19, 2024
| }; | ||
| } | ||
|
|
||
| // Log the fields |
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Updated
typescript/fiddle-frontend/vercel-build.shto install LLVM and Clang usingdnf - Ensures Rust code can be built and compiled in environments lacking these tools
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
hellovai
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.