Adding support for a sync client for Python + Typescript #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hellovai
commented
Jul 19, 2024
hellovai
commented
- Streaming in sync is support for Python as well
- This resolves some issues with celery
* Streaming in sync is support for Python as well * This resolves some issues with celery
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added
default_client_modeparameter todocs/docs/calling-baml/generate-baml-client.mdx. - Introduced sync and async client examples in
docs/docs/get-started/quickstart/python.mdx. - Updated
configuration.rsto handle default client modes for different generator types. - Enhanced error handling in
v0.rs,v1.rs, andv2.rswithnew_anyhow_error. - Introduced synchronous streaming support in
engine/baml-runtime/src/types/stream.rs.
28 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| where | ||
| F: Fn(FunctionResult) -> (), | ||
| { | ||
| let rt = self.tokio_runtime.clone(); |
There was a problem hiding this comment.
Logic: Potential performance issue: Blocking the Tokio runtime could lead to performance degradation.
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Enhanced parsing of Python types for Pydantic models in
engine/language_client_python/src/parse_py_type.rs - Added
test_dynamic_inputs_list2tointeg-tests/python/tests/test_functions.pyfor dynamic input handling - Updated
typescript/fiddle-frontend/vercel-build.shto install LLVM and Clang for WASM module building
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
This was referenced Jul 19, 2024
Closed
hellovai
added a commit
that referenced
this pull request
Jul 19, 2024
hellovai
added a commit
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.