-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contributing.md
#463
Add contributing.md
#463
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
=======================================
Coverage 77.74% 77.74%
=======================================
Files 40 40
Lines 3612 3612
=======================================
Hits 2808 2808
Misses 804 804 ☔ View full report in Codecov by Sentry. |
Have you ever heard of pre-commit-hooks? That could simplify your work. I've seen that you format your code with black by default. The pre-commit hooks would do this before pushing. You can also configure them so that the tests run through, or set ruff as a linter before pushing. |
I do use ruff as a linter locally, but I haven't enabled it on GHA yet as there is a lot that it would pick up. Have been meaning to for quite some time go through and do a general cleanup & refactor. |
I haven't used pre-commit hooks, but would certainly be open to adding them. |
Try working with it locally, it can be annoying with many small commits, because it tests the changed files and changes them if necessary, so that you have to commit again. It can also be tedious to set it up once, as it is best practice during installation to run the pre-commit hooks on all files. If you like it, we can also set it up together. The great added value that I see, especially in open source projects with many contributors, is that the contributed code is already tested locally and formatted if necessary, so that there are no more commits than necessary. |
It might also be a good idea to offer a second requirements.txt that contains the additional functionality for the contributors. This would also be maintainable via the GHA without additional effort. |
I found that a slight rearrangement of the MN directory tree helped me work on the GUI panels and live test them in a Blender instance. I moved the Without this rearrangement, once having made changes to MN code, I would have to copy those altered files to a MN version that is importable as a Blender addon. This is just a small nuisance but has led me to screwing up a few times, where I was left head-scratching about code when I had just forgotten to do the copy. Maybe you all have a better approach to this? The one issue that I think might arise is whether git-checkout can detect changes in files like the |
@rbdavid with the Blender VSCode plugin, you can set it so that every time you save a file it refreshes the add-on. This is how I have it set up so every time I make a change it updates the GUI straight away. |
I like the explanations very much and they are an excellent starting point. |
Adds some documentation for contributing. Plenty to still include and expand upon.