Fix custom nodes #481
Merged
Fix custom nodes #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.1 #481 +/- ##
==========================================
- Coverage 76.02% 75.28% -0.74%
==========================================
Files 40 41 +1
Lines 3716 3731 +15
==========================================
- Hits 2825 2809 -16
- Misses 891 922 +31 ☔ View full report in Codecov by Sentry. |
it seems that there is now a blender 4.1 issue where even if the underlying `.vdb` changes, if you reimport the file it still uses the preview for the 'old' version. Because of this, the created .vdb file path now contains whether or not it was centred and inverted, which makes different files and fixes the issues.
BradyAJohnston
force-pushed
the
fix-custom-nodes
branch
from
07486b3 to
e504149
Compare
This was
linked to
issues
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the creation of custom nodes in 4.1, as well as bumping
bpyand python verisons to 4.1 and 3.11 repsectively.There seem to be a number of problems with
bpy 4.1though. It is unable to be installed on macos. The tests pass on other platforms but the GHA are reporting failure. If I run the test suite through Blender though it passes.