-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server/generate_once] write sessionData caches to file #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
grqz
commented
Sep 14, 2024
- [server/generate_once] Better logging - [server/generate_once] Parse date with new Date() - [server/session_manager] add exporting interface YoutubeSessionDataCaches - [server/session_manager] add private property TOKEN_TTL_HOURS to SessionManager - [server/session_manager] add public method cleanupCaches, getYoutubeSessionDataCaches(boolean), setYoutubeSessionDataCaches(YoutubeSessionDataCaches) - [server/session_manager+generate_once] automatically cleanup caches - [server/session_manager] rename private property youtubeSessionData to youtubeSessionDataCaches
This reverts commit dc227b2. modified: CONTRIBUTING.md
grqz
changed the title
[server]scipt_caches
[server/generate_once] write sessionData caches to file
Sep 14, 2024
Brainicism
requested changes
Sep 14, 2024
fix `Conversion of type 'Date' to type 'string' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.ts(2352)` Co-authored-by: Brian Le <[email protected]>
Co-authored-by: Brian Le <[email protected]>
grqz
commented
Sep 14, 2024
grqz
commented
Sep 14, 2024
grqz
commented
Sep 15, 2024
grqz
commented
Sep 15, 2024
grqz
commented
Sep 15, 2024
Co-authored-by: N/Ame <[email protected]>
Co-authored-by: N/Ame <[email protected]>
…dlp-pot-provider into server/scipt_caches
Brainicism
approved these changes
Sep 15, 2024
- use independent `log` instead of using `sessioinManager.log`
always log the script's stderr output
grqz
commented
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.