-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration Validator 2.0 #1223
Conversation
…h options to view more details and export the logs Added a popup dialog displaying the Integration Validator results with options to view more details and export the logs
Got deep link validator dialog showing
…outing Added spinner with the different choices of deep link keys used for routing
…choice Next button loads the correct content for step 2 based on the user's choice
Branch-SDK/src/main/java/io/branch/referral/validators/IntegrationValidatorDialog.java
Outdated
Show resolved
Hide resolved
Removed unneeded permissions
Used IBranchLoggingCallbacks to retrieve the Branch logs
Added code to generate the various types of Branch links for testing
Laid out the UI for step 3 of the modal (link & use case testing)
…psulate each row Added constants and built out a deep link validator row class to encapsulate each row
Got the info buttons showing the relevant tooltips
Added share button functionality
…ink issue Added debug button functionality to show popup with how to fix deep link issue
…oded specifics Logic refactors so that each row uses uniform, modular code vs. hardcoded specifics
Added foreground click use case
Added warm start test case logic + some bugfixes
Params bugfixes
…ator-2.0 # Conflicts: # Branch-SDK/src/main/res/drawable/branch_icon.png
Merged the Deep Linking Validator and the Integration Validator.
@nsingh-branch - I've merged the Deep Linking Validator into here. Now there is a button at the bottom of the Integration Validator dialog so that the deep linking validator can be utilized without the client having to run that code separately. Please LMK if any changes are needed. The only outstanding items based on our prior discussion are:
Happy to make any changes that you, @NidhiDixit09 , or @gdeluna-branch request. Thanks! cc: @ahmednawar |
Branch-SDK-TestBed/src/main/java/io/branch/branchandroidtestbed/MainActivity.java
Outdated
Show resolved
Hide resolved
Branch-SDK/src/main/java/io/branch/referral/validators/LinkingValidatorConstants.java
Outdated
Show resolved
Hide resolved
Branch-SDK/src/main/java/io/branch/referral/validators/IntegrationValidatorDialogRowItem.java
Show resolved
Hide resolved
Branch-SDK/src/main/java/io/branch/referral/validators/IntegrationValidatorDialog.java
Outdated
Show resolved
Hide resolved
Branch-SDK/src/main/java/io/branch/referral/validators/IntegrationValidatorDialog.java
Outdated
Show resolved
Hide resolved
Branch-SDK/src/main/java/io/branch/referral/validators/AlternateDomainsCheck.java
Outdated
Show resolved
Hide resolved
Refactors based on Gabe's PR feedback (1 of 2)
Refactors based on Gabe's PR feedback (2/2)
Hey @gdeluna-branch thank you for reviewing this PR! I made all of the changes you requested except for one, noted above, where each check is its own object so it wouldn't be possible to refactor the constructor to just take in one object. But please LMK if I am mistaken and I'm happy to take another look. Regarding next steps:
cc: @ahmednawar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking some feedback offline
Thanks Gabe! Now that the offline feedback has been resolved and legal gave us their approval, sending this back your way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
Added a popup dialog displaying the Integration Validator results with options to view more details and export the logs
Reference
No ticket
Description
Clients that I've worked with were running into pain points when using the integration validator. On Android, the validator also did not have the popup functionality that iOS currently has. With the Integration Validator 2.0, clients can:
Testing Instructions
Risk Assessment [
HIGH
||MEDIUM
||LOW
]LOW
Reviewer Checklist (To be checked off by the reviewer only)
cc @BranchMetrics/saas-sdk-devs for visibility.