Expose native layer Integration Validator #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…settings.gradle Fixed an Android build error by using @react-native/gradle-plugin in settings.gradle
…egration" button in there Added a testing section to the App.tsx file with an "Validate SDK Integration" button in there
Got the validator working for Android
Got the validator working for iOS
Updated packages-lock file (fixed build error)
Updated dependencies to fix build errors
…t still worked without the dependency Removed dependency per Gabe's PR feedback and tested to ensure that it still worked without the dependency
gdeluna-branch
approved these changes
Dec 10, 2024
|
There are some merge conflicts, but code looks good |
…e-branch-deep-linking-attribution into ExposeNativeLayerInterationValidator # Conflicts: # branchreactnativetestbed/android/settings.gradle # branchreactnativetestbed/package-lock.json # branchreactnativetestbed/package.json
Updates to the testbed app
|
@gdeluna-branch I fixed the merge conflicts and re-tested on Android and iOS to make sure they didn't break anything. |
gdeluna-branch
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
No ticket. Done to make it easier for clients to test & validate their Branch integration.
Summary
Exposed the native Android and iOS validators so that customers can make a single call at the JS layer to run the validator on whatever platform their app is running on.
Motivation
Currently, there is no way to run the Integration Validator from JS code. We have to tell clients to edit the native code, which isn't ideal and gets pushback from some customers. Others are confused as to how to do that. With this change, clients can run one line of code branch.validateSDKIntegration() to use the Integration Validator.
Type Of Change
Testing Instructions
cc @BranchMetrics/saas-sdk-devs for visibility.