Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2249] Expose the setDMAParamsForEEA method #957

Merged
merged 5 commits into from
Mar 1, 2024
Merged

Conversation

nsingh-branch
Copy link
Contributor

Reference

SDK-2249 -- Expose the setDMAParamsForEEA method

Summary

Expose the setDMAParamsForEEA method in the JS layer and bump the native SDK versions.

Motivation

So clients can utilize the method in React Native and stay compliant.

Type Of Change

  • New feature (non-breaking change which adds functionality)

Testing Instructions

Call the method like Branch.setDMAParamsForEEA(true, true, true); and observe the following request payloads for the respective DMA fields.

cc @BranchMetrics/saas-sdk-devs for visibility.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 31.34328% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 44.24%. Comparing base (247c090) to head (5b6acb5).

Files Patch % Lines
src/index.js 31.34% 39 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #957      +/-   ##
==========================================
- Coverage   47.65%   44.24%   -3.42%     
==========================================
  Files           4        4              
  Lines         256      278      +22     
  Branches       78       88      +10     
==========================================
+ Hits          122      123       +1     
- Misses         98      116      +18     
- Partials       36       39       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@echo-branch
Copy link
Contributor

Was able to set the DMA parameters on iOS and see them in logs. So it looks like the happy path works.

Copy link
Contributor

@echo-branch echo-branch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good in my testing. I think the automation failure is maybe due to the removal of the deprecated API?

@nsingh-branch nsingh-branch merged commit 4db1afe into master Mar 1, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants