[SDK-2326] Add setAPIUrl to the JS layer #967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #967 +/- ##
==========================================
- Coverage 44.24% 43.81% -0.43%
==========================================
Files 4 4
Lines 278 283 +5
Branches 88 89 +1
==========================================
+ Hits 123 124 +1
- Misses 116 119 +3
- Partials 39 40 +1 ☔ View full report in Codecov by Sentry. |
| @@ -164,6 +164,17 @@ class Branch { | |||
| console.warn("setDMAParamsForEEA: Unable to set DMA params."); | |||
| } | |||
| }; | |||
|
|
|||
| /*** Set the Branch API's base URL (eg. "https://api2.branch.io") ***/ | |||
| setAPIUrl = (apiUrl) => { | |||
There was a problem hiding this comment.
I recommend removing the JavaScript API and moving this to the native JSON api. The JS <> native runtime switch will be a race condition against this setting which must be called before session init.
Instead, the json can be read on the native init's start up.
|
|
||
| /*** Set the Branch API's base URL (eg. "https://api2.branch.io") ***/ | ||
| setAPIUrl = (apiUrl) => { | ||
| if (!apiUrl || typeof apiUrl !== "string" || !apiUrl.startsWith("http")) { |
There was a problem hiding this comment.
A full url validation
const urlPattern = new RegExp('^(https?)://((([a-z\\d]([a-z\\d-]*[a-z\\d])*)\\.)+[a-z]{2,}|((\\d{1,3}\\.){3}\\d{1,3}))(\\:\\d+)?(\\/[-a-z\\d%_.~+]*)*(\\?[;&a-z\\d%_.~+=-]*)?(\\#[-a-z\\d_]*)?$', 'i');
urlPattern.test(apiUrl);
|
Closing in favor of using branch.json |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
SDK-2326 -- Expose the setAPIUrl method in the JS layer
Summary
Added the setAPIUrl to the JS layer now that it exists on both of the native layers.
Motivation
Bring the React Native SDK to parity with out iOS and Android native SDKs.
Type Of Change
Testing Instructions
Call the new method with a cusrtom API URL. To have the initial open/install use the endpoint, it needs to be set early.
Calling
branch.setAPIUrl('https://api3.branch.io')in the Testbed'scomponentDidMountworks in that case.cc @BranchMetrics/saas-sdk-devs for visibility.