Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2468] update unit test imports #997

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

JagadeeshKaricherla-branch
Copy link
Contributor

@JagadeeshKaricherla-branch JagadeeshKaricherla-branch commented Jul 6, 2024

Summary

  • fix lint errors
  • update unit test imports to use src instead of library(in node_modules)
  • abstract RNBranch to support new platforms apart from ios and Android in nativemodules

Motivation

Type Of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing Instructions

npm run test

cc @BranchMetrics/saas-sdk-devs for visibility.

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.56%. Comparing base (492070c) to head (fb7205a).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #997       +/-   ##
===========================================
+ Coverage   44.24%   69.56%   +25.32%     
===========================================
  Files           4        3        -1     
  Lines         278      138      -140     
  Branches       88       47       -41     
===========================================
- Hits          123       96       -27     
+ Misses        116       23       -93     
+ Partials       39       19       -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JagadeeshKaricherla-branch JagadeeshKaricherla-branch changed the title update unit test imports [SDK-2468] update unit test imports Jul 9, 2024
@JagadeeshKaricherla-branch JagadeeshKaricherla-branch merged commit a05009f into master Jul 26, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants